support blink cursor, and fix underscore's cursorshape #8990
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close: #8988
Thanks to new crossterm version, nushell can support blink cursor shape. It can be config with the following value:
And original block, line, underscore will be steady. It also fixes wrong shape of
underscore
.User-Facing Changes
Here is a little breaking change, before the change:
line
cursor shape is blinking line, but after this pr, it will besteady line
. To make a blink line, we need to change the value toblink_line
.But I think it's ok, because after the change, we have a good naming convention about the name of shape
Tests + Formatting
After Submitting