Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support blink cursor, and fix underscore's cursorshape #8990

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

WindSoilder
Copy link
Collaborator

@WindSoilder WindSoilder commented Apr 25, 2023

Description

Close: #8988

Thanks to new crossterm version, nushell can support blink cursor shape. It can be config with the following value:

  1. blink_block
  2. blink_line
  3. blink_underscore

And original block, line, underscore will be steady. It also fixes wrong shape of underscore.

User-Facing Changes

Here is a little breaking change, before the change: line cursor shape is blinking line, but after this pr, it will be steady line. To make a blink line, we need to change the value to blink_line.

But I think it's ok, because after the change, we have a good naming convention about the name of shape

Tests + Formatting

After Submitting

@fdncred
Copy link
Collaborator

fdncred commented Apr 25, 2023

nice! I wonder if these additional ones were introduced with crossterm 26 or we just missed them the first time?

@WindSoilder
Copy link
Collaborator Author

Yeah, they are introduced with crossterm 26. We didn't miss them before

@amtoine
Copy link
Member

amtoine commented Apr 25, 2023

is it normal that this should close #8988 but #8988 is already closed? 😮

@WindSoilder
Copy link
Collaborator Author

Not really :-) @fdncred provides a good solution for that issue. But the pr provides another way to do this

@fdncred fdncred merged commit 5733a13 into nushell:main Apr 26, 2023
@fdncred
Copy link
Collaborator

fdncred commented Apr 26, 2023

Thanks. As always, good job!

@amtoine
Copy link
Member

amtoine commented Apr 26, 2023

@WindSoilder gotcha, thanks 😋

@WindSoilder WindSoilder deleted the blink_cursor branch April 26, 2023 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to disable line cursor blinking?
3 participants