Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix cursor position when cursor is at the end of the commandline #9030

Merged
merged 2 commits into from
Apr 28, 2023

Conversation

stevenxxiu
Copy link
Contributor

@stevenxxiu stevenxxiu commented Apr 28, 2023

Description

Fix getting the cursor position, when it's at the end of the commandline.

User-Facing Changes

Tests + Formatting

After Submitting

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Merging #9030 (05d4d41) into main (35c8485) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #9030   +/-   ##
=======================================
  Coverage   68.76%   68.77%           
=======================================
  Files         640      640           
  Lines      101433   101434    +1     
=======================================
+ Hits        69753    69763   +10     
+ Misses      31680    31671    -9     
Impacted Files Coverage Δ
crates/nu-cli/src/commands/commandline.rs 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@stevenxxiu stevenxxiu force-pushed the fix/commandline-get-cursor-at-end branch from 60ec773 to 05d4d41 Compare April 28, 2023 10:19
@stevenxxiu stevenxxiu changed the title Fix/commandline get cursor at end fix: fix cursor position when cursor is at the end of the commandline Apr 28, 2023
@stevenxxiu stevenxxiu marked this pull request as draft April 28, 2023 10:30
@stevenxxiu stevenxxiu marked this pull request as ready for review April 28, 2023 10:34
@fdncred
Copy link
Collaborator

fdncred commented Apr 28, 2023

Thanks! Appreciate the added tests too.

@fdncred fdncred merged commit b37662c into nushell:main Apr 28, 2023
@stevenxxiu stevenxxiu deleted the fix/commandline-get-cursor-at-end branch April 28, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants