Break up interdependencies of command crates #9429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move `help` commands from `nu-cmd-lang` back to `nu-command` - Make `nu-cmd-lang` only a dev dependency for `nu-command` - Change context creation helpers for `nu-cmd-extra` and `nu-cmd-dataframe` to have a consistent api used in `src/main.rs`:`get_engine_state()` - `nu-command` now indepedent from `nu-cmd-extra` and `nu-cmd-dataframe` that are now dependencies of `nu` directly. (change to internal features) - Fix tests that previously used `nu-command::create_default_context()` with replacement functions
sholderbach
force-pushed
the
command-para
branch
from
002c8a5
to
e000949
Compare
Move `nu-cmd-lang` to dev-dependencies as no longer needed for the crate function only relevant in tests.
|
With the feature |
amtoine
approved these changes
Jun 14, 2023
There was a problem hiding this comment.
i think this looks great and yet another step in the right direction, thanks @sholderbach 😊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make sure that our different crates that contain commands can be compiled in parallel.
This can under certain circumstances accelerate the compilation with sufficient multithreading available.
Details
helpcommands fromnu-cmd-langback tonu-commandnu-cmd-langonly a dev dependency fornu-commandnu-cmd-extraandnu-cmd-dataframeto have a consistent api used insrc/main.rs:get_engine_state()nu-commandnow indepedent fromnu-cmd-extraandnu-cmd-dataframethat are now dependencies ofnudirectly. (change to internal features)nu-command::create_default_context()with replacement functionsFrom scratch compilation times:
just debug (dev) build and default features
before
after
User-Facing Changes
None direct, only change to compilation on multithreaded jobs expected.
Tests + Formatting
Tests that previously chose to use
nu-commandfor their scope will still usenu-cmd-lang+nu-command(command list in the granularity at the time)