prompt moves based on hint

[elferherrera]

The prompt moves and gives space to hint when it is located at the bottom.

the prompt moves upwards based on the suggestion

Note: This also removes the issue when the suggestion was being redrawn every second

[sholderbach]

Awesome that you are tackling that! I like the simplification. Will try to give it a thorough testing

[sholderbach]

Bikeshed: BufferView as it does not care about the Prompt directly and View may reflect the reference nature. Same for the lifetime name

[sophiajt]

Seeming some places where we need to output /r/n to keep things aligned:

[elferherrera]

@jntrnr can you check with the new commit?

[sophiajt]

@elferherrera same issue -

[elferherrera]

@jntrnr @sholderbach @fdncred do you mind checking the new commit?

[sophiajt]

@elferherrera - same issue

[fdncred]

ya, same for me too.

[elferherrera]

@fdncred @sholderbach do you mind checking again this commit?

[sholderbach]

Looking good to me. Even wrapping lines seem to be good at the bottom of the screen. The only thing i noticed that if the last line is reached with actual content, it jumps up a line to leave a blank line after a full repaint.

[fdncred]

I'd land this one and continue to work on other issues like 'very long buffer' and 'jumps up a line'.

[elferherrera]

@fdncred I think that is a good idea. I dont want to make the PR larger

[sophiajt]

Tried out the latest - it doesn't seem to let you work with the last line of the screen:

I also noticed that if you have a multiline history hint at the bottom, clock tick scrolls:

The other odd thing in that second one: notice where the cursor is, but I'm typing on the line above it.

[sophiajt]

Here's an animation to see these a little bit better:

[fdncred]

it's interesting that I don't get this behavior on Mac.

[sophiajt]

@elferherrera - thanks for banging this into shape!