Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odd moving of text when on bottom row of terminal #76

Closed
fdncred opened this issue Jun 23, 2021 · 7 comments
Closed

odd moving of text when on bottom row of terminal #76

fdncred opened this issue Jun 23, 2021 · 7 comments
Labels
A-Display Area: Correctness of the display output and additional features needed there bug Something isn't working P-medium Medium Priority: Bug affects quality of life, feature would improve experience for all

Comments

@fdncred
Copy link
Collaborator

fdncred commented Jun 23, 2021

this is hard to describe but it appears that in Windows using Windows Terminal, when you're on the bottom row of the terminal and you type something like 'now is the time for all good men' and hit enter, it briefly moves the text ~10 characters to the right, then accepts the text and prints it as normal. It's really odd and hard to explain.

I reproduce this by doing:

  1. clear
  2. cargo clean
  3. cargo run
  4. ls
  5. now is the time for all good men
  6. and watch it shift and then accept

i've tried to capture it with screentogif but i'm not able to.

ok, here's what it's doing. i changed screentogif to run at 60 fps and i caught the error. here are the 3 frames.

frame 1 - when i typed in some (any) text
image

frame2 - the flashing that i see, which i characterized above as ~10 chars to the right. it actually is moving the text to the right because it's prefixed by Our buffer:
image

frame3 - when it accepts the text
image

ahkrr pushed a commit to ahkrr/reedline that referenced this issue Jun 23, 2021
sophiajt pushed a commit that referenced this issue Jun 25, 2021
* fix: overwriting of line #76

* fix: overwriting_line

Co-authored-by: ahkrr <alexhk@protonmail.com>
@sholderbach
Copy link
Member

Triage: Has this been resolved on Windows by the fixes from #77?

@stormasm
Copy link
Contributor

Same exact issue on the Mac as described in #132

@fdncred
Copy link
Collaborator Author

fdncred commented Aug 20, 2021

@sholderbach I haven't tested recently. Feel free to close this issue if you think it's fixed by #77.

@stormasm
Copy link
Contributor

stormasm commented Aug 20, 2021

@fdncred @sholderbach this issue is not fixed on the mac...
Everything is strange and weird at the bottom row of the terminal on the mac as described in #132
Where as if I do a Ctrl-L and I am at the top of screen everything works as it should.

The way to reproduce this is inside engine-q (on a mac) simply add a println! debug statement to any loop in the parser and you will see the behavior...

@fdncred
Copy link
Collaborator Author

fdncred commented Aug 20, 2021

oh, @stormasm, I thought you were saying that issue #132 wasn't fixed on the mac. Sorry.

@stormasm
Copy link
Contributor

@fdncred yep ---- sorry about that ---- I should have been more clear...

@sholderbach sholderbach added the bug Something isn't working label Nov 7, 2021
@sholderbach sholderbach added A-Display Area: Correctness of the display output and additional features needed there P-medium Medium Priority: Bug affects quality of life, feature would improve experience for all labels Nov 28, 2021
@sholderbach
Copy link
Member

Probably out of date, painting logic and handling of the bottom of the screen case was changed significantly with #217

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Display Area: Correctness of the display output and additional features needed there bug Something isn't working P-medium Medium Priority: Bug affects quality of life, feature would improve experience for all
Projects
None yet
Development

No branches or pull requests

3 participants