-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
odd moving of text when on bottom row of terminal #76
Comments
Triage: Has this been resolved on Windows by the fixes from #77? |
Same exact issue on the Mac as described in #132 |
@sholderbach I haven't tested recently. Feel free to close this issue if you think it's fixed by #77. |
@fdncred @sholderbach this issue is not fixed on the mac... The way to reproduce this is inside engine-q (on a mac) simply add a println! debug statement to any loop in the parser and you will see the behavior... |
@fdncred yep ---- sorry about that ---- I should have been more clear... |
Probably out of date, painting logic and handling of the bottom of the screen case was changed significantly with #217 |
this is hard to describe but it appears that in Windows using Windows Terminal, when you're on the bottom row of the terminal and you type something like 'now is the time for all good men' and hit enter, it briefly moves the text ~10 characters to the right, then accepts the text and prints it as normal. It's really odd and hard to explain.
I reproduce this by doing:
i've tried to capture it with screentogif but i'm not able to.
ok, here's what it's doing. i changed screentogif to run at 60 fps and i caught the error. here are the 3 frames.
frame 1 - when i typed in some (any) text
frame2 - the flashing that i see, which i characterized above as ~10 chars to the right. it actually is moving the text to the right because it's prefixed by
Our buffer:
frame3 - when it accepts the text
The text was updated successfully, but these errors were encountered: