Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incomplete key sequences should be completed first #693

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

crides
Copy link
Contributor

@crides crides commented Jan 2, 2024

Fixes an issue like #473 and #449, but for custom keybindings. Fixed by checking if the current key sequence is complete, and if not, complete it before checking for keybindings.

Added a test for this scenario

@crides crides force-pushed the incomplete-key-seq branch 2 times, most recently from 7673d86 to b44c463 Compare January 3, 2024 06:44
@fdncred
Copy link
Collaborator

fdncred commented Feb 9, 2024

Hey @crides, Will you be continuing to work on this PR or are you out of time/decided it's not useful?

@crides
Copy link
Contributor Author

crides commented Feb 9, 2024

From local testing I think it's done

@fdncred
Copy link
Collaborator

fdncred commented Feb 9, 2024

the ci doesn't agree with you. 😆

@crides
Copy link
Contributor Author

crides commented Feb 9, 2024

Huh, a bunch of things I didn't touch. I can fix later today

@crides crides force-pushed the incomplete-key-seq branch 2 times, most recently from f6ff6a8 to edc57d3 Compare February 10, 2024 05:46
@crides
Copy link
Contributor Author

crides commented Feb 10, 2024

aight there we go

@crides
Copy link
Contributor Author

crides commented Feb 10, 2024

hmm this is not actually general enough (not accounting for insert mode bindings) but I don't think such a case can exist in insert mode right now (not even for custom bindings)? Examples in normal vim/zsh vi mode will be ^V and ^K for inserting characters/digraphs; or ^O if you wanna include that (temporary exit to normal mode; see :h i_^O)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants