use which to search nu location, add icon too.
#153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if the profile provider returns undefined, users will get a confusing error message: ``` No terminal profile options provided for id "nushell_default" ``` if we instead just return a program name "nu", the error message became: ``` path to shell executable "nu" does not exist ``` which should give the user more clue what went wrong.
fdncred
reviewed
Sep 16, 2023
fdncred
reviewed
Sep 16, 2023
fdncred
reviewed
Sep 16, 2023
fdncred
reviewed
Sep 16, 2023
|
I think this is an excellent idea. Thanks for adding this. I just had a few notes above. Appreciate your help! yup, the svg icon is a good call. |
the error message also guide the user to install `nushell` from website and reload vscode.
|
ok. I think we're good here if we can just get the ci green. thanks for your help and explanations! I wrote this mess, with some help, but I'm no good at javascript/typescript stuff. :) |
|
oops, look like the linter doesn't like an empty function body. replaced with an empty value. should fix it now. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried out the vscode extension today and it gave error. so I looked at the code and found out the
nuinstallation detection logic is manually searching through a hard coded list of directores, but my setup happens to be not in any of the presumed locations. so I modified the code to usewhichto search in${env:PATH}, plus these additional locations, and also simplfied the code a little bit during the process.also, I don't like the generic "terminal" icon, and I find there's already a svg icon file in the assets folder so I just point the terminal profile icon path to that svg file.