Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use which to search nu location, add icon too. #153

Merged
merged 5 commits into from
Sep 17, 2023
Merged

use which to search nu location, add icon too. #153

merged 5 commits into from
Sep 17, 2023

Commits on Sep 16, 2023

  1. Configuration menu
    Copy the full SHA
    65c37ca View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9c3fa8b View commit details
    Browse the repository at this point in the history
  3. change behavior in case nu cannot be found.

    if the profile provider returns undefined, users will get a confusing error message:
    
    ```
    No terminal profile options provided for id "nushell_default"
    ```
    
    if we instead just return a program name "nu", the error message became:
    
    ```
    path to shell executable "nu" does not exist
    ```
    
    which should give the user more clue what went wrong.
    nerditation committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    122138d View commit details
    Browse the repository at this point in the history
  4. add detailed error message on failure.

    the error message also guide the user to install `nushell` from website and reload vscode.
    nerditation committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    8f4af9c View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2023

  1. Configuration menu
    Copy the full SHA
    ca67d6e View commit details
    Browse the repository at this point in the history