-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prerequisite tree right-to-left progression is confusing #3202
Comments
I think the original thinking is people want to know the dependencies rather than the dependents. You're right, it's a little confusing to display it this way. Top to bottom is more intuitive but it's hard to do in css. |
I'd like to take this issue please #3263 |
hey @schalkneethling do you mind if I take this up? I think I've created a working version with reverse ordering. |
I've created a pull request for this issue above. |
Hey @alvynben, thanks for the contribution! However since @sciffany already has a working implementation in #3263, we'll review her version first. (I think there was a miscomm somewhere above.) If you'd like to, you can review her PR too! I'm going to close your PR first to avoid confusion (we can reopen it again if the need arises). Sorry about that! |
Is your feature request related to a problem? Please describe.
Some module pages (example) have prerequisite trees, where a given modules' dependents and prerequisites are displayed on the module's left and right respectively. However, this is counter-intuitive to people who expect a left to right progression.
Describe the solution you'd like
We should probably flip the tree to show dependents on the right.
Describe alternatives you've considered
@li-kai any idea why we did it this way?
The text was updated successfully, but these errors were encountered: