Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: Temporarily directly use GitHub API for contributor list #3655

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

kokrui
Copy link
Member

@kokrui kokrui commented Feb 20, 2024

Context

The github.nusmods.com/repo and github.nusmods.com/venue API proxies are down. This means the contributor list is down and the venue list uses the bundled venue list.

Implementation

  • For contributor list, use GitHub's API directly. This could result in exceeding rate limits (and the contributor list going back down) if the /contributors page is suddenly very popular, but it's better than being down 100% of the time
  • For venues, just make a note that the bundled list is always used. Venues themselves won't actually be impacted

Copy link

vercel bot commented Feb 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nusmods-export ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 3:25am
nusmods-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 3:25am

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (82927f6) 53.48% compared to head (03b872c) 53.49%.

Files Patch % Lines
website/src/apis/github.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3655      +/-   ##
==========================================
+ Coverage   53.48%   53.49%   +0.01%     
==========================================
  Files         272      272              
  Lines        5931     5931              
  Branches     1408     1408              
==========================================
+ Hits         3172     3173       +1     
+ Misses       2759     2758       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kokrui kokrui merged commit 3f3f7a3 into master Feb 20, 2024
5 of 6 checks passed
@kokrui kokrui deleted the kokrui/temp-restore-contributors branch February 20, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant