Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Endless loop in timeout function for long-running actions returning undefined #205

Closed
svettwer opened this issue Jan 25, 2021 · 0 comments · Fixed by #206
Closed

Endless loop in timeout function for long-running actions returning undefined #205

svettwer opened this issue Jan 25, 2021 · 0 comments · Fixed by #206
Assignees
@svettwer
Labels
bug Something isn't working

Comments

@svettwer
Copy link
Contributor

svettwer commented Jan 25, 2021 •
edited
Loading

Version
1.5.0

Short overview
Using the timeout function from poll-action.function.ts results in an endless loop, if the action takes longer than the maximum timeout and returns undefined. This causes validateResult to execute the action over and over again.

Relates to sakuli/sakuli#583
@svettwer svettwer added the bug Something isn't working label Jan 25, 2021
@svettwer svettwer self-assigned this Jan 25, 2021
@svettwer svettwer changed the title endless loop in timeout function for long running actions returning undefined endless loop in timeout function for long-running actions returning undefined Jan 25, 2021
@svettwer svettwer changed the title endless loop in timeout function for long-running actions returning undefined Endless loop in timeout function for long-running actions returning undefined Jan 25, 2021
svettwer added a commit that referenced this issue Jan 25, 2021
@svettwer
(#205) fixed timer handling in validateResult
c7642af
@svettwer svettwer mentioned this issue Jan 25, 2021
Merged
svettwer added a commit that referenced this issue Feb 2, 2021
@svettwer
(#205) Applied refactoring proposed in review
77967bf
svettwer added a commit that referenced this issue Feb 5, 2021
@svettwer
Merge pull request #206 from nut-tree/fix/205/timeout-endless-loop
dcaed48 
(#205) fixed timer handling in validateResult
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@svettwer svettwer

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(#205) fixed timer handling in validateResult nut-tree/nut.js
1 participant
@svettwer