Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging Improvements #10

Merged
merged 3 commits into from
Aug 1, 2022
Merged

Logging Improvements #10

merged 3 commits into from
Aug 1, 2022

Commits on Aug 1, 2022

  1. Various surface-level changes to class Logger 

    - Renamed WriteLogValue to WriteToFile to better communicate its purpose
- Disabled references to WinNUT_Globals.LogFilePath for better OOP design
- Add XML doc to LogTracing subrouting as best as I understand it
- (Also disabled updating the LogFilePath global variable in here, too)
    @gbakeman
    gbakeman committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    ed88a65 View commit details
    Browse the repository at this point in the history

  2. Logging-related improvements 

    - WinNUT_Globals:
  - Move AppData directory info to a Property, and return different values if debugging or not.
  - Logger object is now stored in globals, rathern than WinNUT.vb
- Logger.vb:
  - BaseFileName is now a const, LogFolder is shared and stored in a subdirectory
  - LogFile writing is now a property that handles setup and shutdown of logging
  - Actual logging setup is moved to its own subrouting, so the class constructor has very little to do.

- Updated/simplified/commented out unnecessary LogFile references.
- Pref_Gui: Simplified log controls, created a subrouting for log control enablement.
- WinNUT.vb:
  - Instantiate Logger at beginning of form load.
  - Relocated logtracing lines to appropriate locations.
  - Renamed local Logger object for events handling.
    @gbakeman
    gbakeman committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    ce5be39 View commit details
    Browse the repository at this point in the history

  3. UPS connection logging improvements 

    - Adjust spacing in connection error string
- Nut_Socket.vb: Enhanced error raising so Nut_Exceptions are passed as-is
- Handle NUT errors at the UPS level. Currently only informative logging is happening here, extra actions taken as a result yet.
    @gbakeman
    gbakeman committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    0870b71 View commit details
    Browse the repository at this point in the history