Fix logs going to App directory again #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Correcting PreRelease build config so that projects are building correctly as needed. - Logger class handles its own directory since the Logging API provides default file locations. - Removing global variables and logic relating to data paths since the only code that really used it was the Logger class. - Specified output path for crashbugs. - Simplified Logger initialization to be more predictable and utilize standard values and paths.
- Added a PreRelease build config to the Common library so the DEBUG constant is not defined and logging behaves like a normal release. - Attempted to clean up project references so the Setup project stops trying to include them. It helped for some of them, and nothing appears to have broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging was broken yet again due to me adding the
PreReleaseconfiguration and neglecting to configure the Common library correctly. The Common library now has aPreReleaseconfiguration that omits theDEBUGconstant so logging behaves like a normal release. In addition, the Logging class depends on .NET Framework constants for determining file location, which means logs now appear in AppData/Roaming/NUTDotNet/WinNUT Client/(current version)/. Finally, some cleanup has been done in and around the Globals file to reduce how much code there is to determine an appropriate data directory in exchange for depending on defaults provided by the Framework.Closes #110