Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Application Settings not carrying over on upgrade/update #140

Merged
merged 3 commits into from
Mar 9, 2024

Conversation

gbakeman
Copy link
Contributor

@gbakeman gbakeman commented Mar 9, 2024

Closes #135 .

Changes

  • Added new IsFirstRun User Setting (default True)
  • Insert block of code in the ApplicationEvents file that checks if this Setting is True, then attempts to call the Upgrade method.
  • Some small cleanup to the default header (removed) and cleaned up AssemblyInfo files.
  • Prepare new Pre Release

Application Settings upgrade routine is only run automatically when using the ClickOnce installer. Since it's not run with our current MSI build, this code will then run when the program is started for the first time (nothing happens) or if it's an upgraded MSI installation with a fresh copy of settings. In that case, the Upgrade function will find the older copy and import/apply them. This operation won't be attempted until the next upgrade. Need to remove once using pure ClickOnce.
Top LICENSE file still applies. Will clean up files as needed. Started by cleaning up assemblyinfo files. Adding some additional information.
@gbakeman gbakeman added bug Something isn't working enhancement New feature or request labels Mar 9, 2024
@gbakeman gbakeman added this to the 2.3 Stable Release milestone Mar 9, 2024
@gbakeman gbakeman self-assigned this Mar 9, 2024
@gbakeman gbakeman linked an issue Mar 9, 2024 that may be closed by this pull request
5 tasks
@gbakeman gbakeman merged commit 8ddab9d into dev-2.3 Mar 9, 2024
1 check passed
@gbakeman gbakeman deleted the 135-setup-enhancements branch March 9, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Program settings not carrying over to new versions
1 participant