Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zh-cn language and add UPS States flag #152

Merged
merged 3 commits into from May 6, 2024

Conversation

MaxMadcc
Copy link
Contributor

@MaxMadcc MaxMadcc commented May 5, 2024

  • Update Language (zh-cn).

  • Fix some translations.

  • Add ECO flag.

  • Add RB flag.

@MaxMadcc MaxMadcc changed the title Update zh-cn language Update zh-cn language and add UPS States flag May 5, 2024
@gbakeman gbakeman merged commit b5fe331 into nutdotnet:dev-2.3 May 6, 2024
1 check passed
@gbakeman
Copy link
Contributor

gbakeman commented May 6, 2024

I apologize for you having to update the labels relating to the Polling interval - I realized users may prefer it being in seconds rather than milliseconds, so I may need you to update that again soon. But I'll merge this in now. Good work, thank you!

@gbakeman gbakeman added this to the 2.3 Stable Release milestone May 6, 2024
@gbakeman
Copy link
Contributor

gbakeman commented May 6, 2024

@MaxMadcc Question for you:

My Visual Studio client persistently wants to reverse some of the changes you made in this commit, do you happen to know why? For example, here's WinNUT.zh-CN.resx:

image

No matter how much I discard the changes, Visual Studio tries to make them again. Do you know if your IDE made the first set of changes automatically too? Do you think it would break anything if I accepted the changes that my IDE wants to make?

@MaxMadcc
Copy link
Contributor Author

MaxMadcc commented May 7, 2024

@MaxMadcc Question for you:

My Visual Studio client persistently wants to reverse some of the changes you made in this commit, do you happen to know why? For example, here's WinNUT.zh-CN.resx:

image

No matter how much I discard the changes, Visual Studio tries to make them again. Do you know if your IDE made the first set of changes automatically too? Do you think it would break anything if I accepted the changes that my IDE wants to make?

Look like my bad. 😲
I remember I use ResXResourceManager easy to fix translation. It will sync between ResX and Xliff resource files.The content on the image was generated by ResXResourceManager.
I took a look, it's okay to delete it.

@gbakeman
Copy link
Contributor

gbakeman commented May 7, 2024

OK, thanks for confirming and thank you again for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants