Battery-related changes #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gbakeman
commented
Oct 1, 2022
•
gbakeman
commented
- Re-enabling runtime calculation field that was disabled in commit 61bf278. Unsure why at this point, possibly related to instant power calculation?
- Also extensive changes to network code, needs testing.
Re-enabling runtime calculation field that was disabled in commit 61bf278. Unsure why at this point, possibly related to instant power calculation?
Closed
- Removed Nut_Exception_Value enum in favor of relying on NUTResponse, which already has the exceptions. Translations for values should be provided elsewhere. - Modified NUTResponse so that no response is considered the default now. - Refactored a few common class names, added constructors - Added the Transaction class to represent a query and response. - NutExceptions now include the original query, response, protocol response enum, and inner exception if available. - Updated socket query methods to be more robust - Some static data is no longer refreshed on the UPS - Refactored GetUPSVar for better error handling, may need to come back to this. - UPS Var view now shows values more consistently.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.