Separate AGauge into a NuGet package, with inherited control #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
May have prevented an update of the battery voltage gauge.
Adds a form specifically for testing an AGauge control to reproduce the drawing bug.
Also upgrading to VS version 17 (2022.)
UPSVarGauge is a custom Forms control that inherits and overrides the AGauge control class. AGauge will be added as a NuGet reference to the latest version (or fork.)
Leaving it in the global Ssytem.Windows.Forms namespace was causing VS to remove type information from Forms objects in the solution view. This class probably didn't belong in a system namespace anyways.
Relocating CProgressBar and UPSVarGauge to a Controls subdirectory. Also removing non-existent .editorconfig from project.
Removing the NuGet package of AGauge and replacing the reference with a compiled binary from the nutdotnet/AGauge project with fixes merged in from @PaulMartinsen
Still needs testing.
Fixed new issue that was introduced where the gradient was not drawing correctly. It seems like the wrong coordinates were being used to calculate the gradient brush. - Corrected naming on gradient orientation enums - Reorganized logic in arc drawing subroutine - Delete unused private fields and organize others
- Updating references to new gauge class
Updating references in WinNUT main form to new gauge class.
- Updated NuGet package reference, removed references to local/external AGauge project - Updating Setup project with changes in references as a result - Removed AGaugeTest form - Removed extra .NET publishing dependency from main project - Moved UPSVarGauge into a Controls namespace, and making explicit references in WinNUT form. - Applying autogenerated OnInitialize function in the Application designer file.
gbakeman
changed the title
No longer need the original modded AGauge files. Also remove an extraneous library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AGauge project in WinNUT is a modified version of the original AGauge project. We have not tracked upstream since the initial modifications were made. Since then, further work has been done on AGauge upstream and related forks.
Solution
Per Code-Artist/AGauge#10, the base AGauge repository is no longer maintained and is missing out on some forked changes that have improved it. A new fork has been started under the organization, at https://github.com/nutdotnet/AGauge. General improvements will be merged in and published to a NuGet page.
For WinNUT, the best way forward is to separate out the AGauge project from the WinNUT solution, then create any further modifications that don't belong in the base AGauge project in a custom class specific for WinNUT.
Will eventually go towards addressing #18 .