Remove destroy() in Plugin

nuun-io · Oct 6, 2015 · 1e0b9d2 · 1e0b9d2
1 parent 673358e
commit 1e0b9d2
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 57 deletions.
diff --git a/core/src/main/java/io/nuun/kernel/core/AbstractPlugin.java b/core/src/main/java/io/nuun/kernel/core/AbstractPlugin.java
@@ -25,36 +25,21 @@
 import io.nuun.kernel.api.plugin.RoundEnvironment;
 import io.nuun.kernel.api.plugin.context.Context;
 import io.nuun.kernel.api.plugin.context.InitContext;
-import io.nuun.kernel.api.plugin.request.BindingRequest;
-import io.nuun.kernel.api.plugin.request.BindingRequestBuilder;
-import io.nuun.kernel.api.plugin.request.ClasspathScanRequest;
-import io.nuun.kernel.api.plugin.request.ClasspathScanRequestBuilder;
-import io.nuun.kernel.api.plugin.request.KernelParamsRequest;
-import io.nuun.kernel.api.plugin.request.KernelParamsRequestBuilder;
+import io.nuun.kernel.api.plugin.request.*;
 import io.nuun.kernel.api.plugin.request.builders.BindingRequestBuilderMain;
 import io.nuun.kernel.core.internal.ModuleEmbedded;
 import io.nuun.kernel.spi.DependencyInjectionProvider;
-
-import java.lang.annotation.Annotation;
-import java.lang.reflect.Field;
-import java.net.URL;
-import java.util.Arrays;
-import java.util.Collection;
-import java.util.Collections;
-import java.util.HashMap;
-import java.util.Map;
-import java.util.Set;
-
-import org.kametic.specifications.AbstractSpecification;
-import org.kametic.specifications.AndSpecification;
-import org.kametic.specifications.NotSpecification;
-import org.kametic.specifications.OrSpecification;
-import org.kametic.specifications.Specification;
+import org.kametic.specifications.*;
 import org.kametic.specifications.reflect.ClassMethodsAnnotatedWith;
 import org.kametic.specifications.reflect.DescendantOfSpecification;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import java.lang.annotation.Annotation;
+import java.lang.reflect.Field;
+import java.net.URL;
+import java.util.*;
+
 /**
  * @author Epo Jemba
  */
@@ -110,11 +95,6 @@ public void start(Context context)
         this.context = context;
     }
 
-    @Override
-    public void destroy()
-    {
-    }
-
     // /**
     // * ============================= PLUGIN Utilities Helpers =============================
     // *

diff --git a/core/src/test/java/io/nuun/kernel/core/pluginsit/dummy1/DummyPlugin.java b/core/src/test/java/io/nuun/kernel/core/pluginsit/dummy1/DummyPlugin.java
@@ -169,11 +169,6 @@ public Collection<Class<? extends Plugin>> requiredPlugins()
         return collectionOf(DummyPlugin2.class);
     }
 
-    @Override
-    public void destroy()
-    {
-    }
-
     @Override
     public void start(Context context)
     {

diff --git a/specs/src/main/java/io/nuun/kernel/api/Plugin.java b/specs/src/main/java/io/nuun/kernel/api/Plugin.java
@@ -51,11 +51,6 @@ public interface Plugin
      */
     void stop();
 
-    /**
-     * Lifecycle method: destroy()
-     */
-    void destroy();
-
     /**
      * The name of the plugin. Plugin won't be installed, if there is no a name. And if this name is not
      * unique. Mandatory.

diff --git a/specs/src/test/java/io/nuun/kernel/api/plugin/request/annotations/TestPlugin.java b/specs/src/test/java/io/nuun/kernel/api/plugin/request/annotations/TestPlugin.java
@@ -22,25 +22,14 @@
 import io.nuun.kernel.api.plugin.RoundEnvironment;
 import io.nuun.kernel.api.plugin.context.Context;
 import io.nuun.kernel.api.plugin.context.InitContext;
-import io.nuun.kernel.api.plugin.request.BindingRequest;
-import io.nuun.kernel.api.plugin.request.BindingRequestBuilder;
-import io.nuun.kernel.api.plugin.request.ClasspathScanRequest;
-import io.nuun.kernel.api.plugin.request.ClasspathScanRequestBuilder;
-import io.nuun.kernel.api.plugin.request.KernelParamsRequest;
-import io.nuun.kernel.api.plugin.request.KernelParamsRequestBuilder;
+import io.nuun.kernel.api.plugin.request.*;
 import io.nuun.kernel.spi.DependencyInjectionProvider;
-
-import java.net.URL;
-import java.util.Arrays;
-import java.util.Collection;
-import java.util.Collections;
-import java.util.HashMap;
-import java.util.Map;
-import java.util.Set;
-
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import java.net.URL;
+import java.util.*;
+
 /**
  * @author epo.jemba{@literal @}kametic.com
  */
@@ -92,11 +81,6 @@ public void start(Context context)
         this.context = context;
     }
 
-    @Override
-    public void destroy()
-    {
-    }
-
     // /**
     // * ============================= PLUGIN Utilities Helpers =============================
     // *