Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove destroy method #43

Merged
merged 1 commit into from
Oct 6, 2015
Merged

Remove destroy method #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
34 changes: 7 additions & 27 deletions core/src/main/java/io/nuun/kernel/core/AbstractPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,36 +25,21 @@
import io.nuun.kernel.api.plugin.RoundEnvironment;
import io.nuun.kernel.api.plugin.context.Context;
import io.nuun.kernel.api.plugin.context.InitContext;
import io.nuun.kernel.api.plugin.request.BindingRequest;
import io.nuun.kernel.api.plugin.request.BindingRequestBuilder;
import io.nuun.kernel.api.plugin.request.ClasspathScanRequest;
import io.nuun.kernel.api.plugin.request.ClasspathScanRequestBuilder;
import io.nuun.kernel.api.plugin.request.KernelParamsRequest;
import io.nuun.kernel.api.plugin.request.KernelParamsRequestBuilder;
import io.nuun.kernel.api.plugin.request.*;
import io.nuun.kernel.api.plugin.request.builders.BindingRequestBuilderMain;
import io.nuun.kernel.core.internal.ModuleEmbedded;
import io.nuun.kernel.spi.DependencyInjectionProvider;

import java.lang.annotation.Annotation;
import java.lang.reflect.Field;
import java.net.URL;
import java.util.Arrays;
import java.util.Collection;
import java.util.Collections;
import java.util.HashMap;
import java.util.Map;
import java.util.Set;

import org.kametic.specifications.AbstractSpecification;
import org.kametic.specifications.AndSpecification;
import org.kametic.specifications.NotSpecification;
import org.kametic.specifications.OrSpecification;
import org.kametic.specifications.Specification;
import org.kametic.specifications.*;
import org.kametic.specifications.reflect.ClassMethodsAnnotatedWith;
import org.kametic.specifications.reflect.DescendantOfSpecification;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import java.lang.annotation.Annotation;
import java.lang.reflect.Field;
import java.net.URL;
import java.util.*;

/**
* @author Epo Jemba
*/
Expand Down Expand Up @@ -110,11 +95,6 @@ public void start(Context context)
this.context = context;
}

@Override
public void destroy()
{
}

// /**
// * ============================= PLUGIN Utilities Helpers =============================
// *
Expand Down
5 changes: 0 additions & 5 deletions core/src/test/java/io/nuun/kernel/core/pluginsit/dummy1/DummyPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,11 +169,6 @@ public Collection<Class<? extends Plugin>> requiredPlugins()
return collectionOf(DummyPlugin2.class);
}

@Override
public void destroy()
{
}

@Override
public void start(Context context)
{
Expand Down
5 changes: 0 additions & 5 deletions specs/src/main/java/io/nuun/kernel/api/Plugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,11 +51,6 @@ public interface Plugin
*/
void stop();

/**
* Lifecycle method: destroy()
*/
void destroy();

/**
* The name of the plugin. Plugin won't be installed, if there is no a name. And if this name is not
* unique. Mandatory.
Expand Down
24 changes: 4 additions & 20 deletions specs/src/test/java/io/nuun/kernel/api/plugin/request/annotations/TestPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,25 +22,14 @@
import io.nuun.kernel.api.plugin.RoundEnvironment;
import io.nuun.kernel.api.plugin.context.Context;
import io.nuun.kernel.api.plugin.context.InitContext;
import io.nuun.kernel.api.plugin.request.BindingRequest;
import io.nuun.kernel.api.plugin.request.BindingRequestBuilder;
import io.nuun.kernel.api.plugin.request.ClasspathScanRequest;
import io.nuun.kernel.api.plugin.request.ClasspathScanRequestBuilder;
import io.nuun.kernel.api.plugin.request.KernelParamsRequest;
import io.nuun.kernel.api.plugin.request.KernelParamsRequestBuilder;
import io.nuun.kernel.api.plugin.request.*;
import io.nuun.kernel.spi.DependencyInjectionProvider;

import java.net.URL;
import java.util.Arrays;
import java.util.Collection;
import java.util.Collections;
import java.util.HashMap;
import java.util.Map;
import java.util.Set;

import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import java.net.URL;
import java.util.*;

/**
* @author epo.jemba{@literal @}kametic.com
*/
Expand Down Expand Up @@ -92,11 +81,6 @@ public void start(Context context)
this.context = context;
}

@Override
public void destroy()
{
}

// /**
// * ============================= PLUGIN Utilities Helpers =============================
// *
Expand Down