Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xml renderer support #129

Merged
merged 11 commits into from
Apr 2, 2017
Merged

Xml renderer support #129

merged 11 commits into from
Apr 2, 2017

Conversation

felipeweb
Copy link
Member

#4

Copy link
Contributor

@marioidival marioidival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, can add some cases with XML rendered data?

@codecov
Copy link

codecov bot commented Mar 30, 2017

Codecov Report

Merging #129 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #129   +/-   ##
======================================
  Coverage    89.6%   89.6%           
======================================
  Files          10      10           
  Lines         827     827           
======================================
  Hits          741     741           
  Misses         55      55           
  Partials       31      31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 832b854...f2edc6d. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 30, 2017

Codecov Report

Merging #129 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #129   +/-   ##
======================================
  Coverage    89.6%   89.6%           
======================================
  Files          10      10           
  Lines         827     827           
======================================
  Hits          741     741           
  Misses         55      55           
  Partials       31      31

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 832b854...38e0278. Read the comment docs.

@felipeweb felipeweb changed the title [WIP] Xml renderer support Xml renderer support Mar 30, 2017
Copy link
Member

@avelino avelino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update readme urls

@felipeweb felipeweb requested a review from avelino March 30, 2017 13:27
@marioidival marioidival merged commit d062e82 into master Apr 2, 2017
@marioidival marioidival deleted the xml branch April 2, 2017 14:41
@marioidival
Copy link
Contributor

@avelino release please 👍

@avelino avelino added this to the 0.1.7 milestone Apr 20, 2017
avelino pushed a commit that referenced this pull request Jul 16, 2020
* implementation and remove comment from test case

* add test

* sync vendor

* fix some tests

* fix tests

* add tests for XML

* try to fix test

* add router to negroni in test

* forget _ in param

* fix ambigous on test that was commented

* add some docs about xml
avelino pushed a commit that referenced this pull request Jul 16, 2020
* implementation and remove comment from test case

* add test

* sync vendor

* fix some tests

* fix tests

* add tests for XML

* try to fix test

* add router to negroni in test

* forget _ in param

* fix ambigous on test that was commented

* add some docs about xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants