fix Invalid insert query if table not has column id #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipeweb
requested review from
avelino,
crgimenes,
marioidival and
cassiobotaro
Current coverage is 86.32% (diff: 63.33%)@@ master #77 diff @@
==========================================
Files 6 6
Lines 730 753 +23
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 635 650 +15
- Misses 64 68 +4
- Partials 31 35 +4
|
avelino
approved these changes
Jan 21, 2017
marioidival
approved these changes
Jan 21, 2017
avelino
pushed a commit
that referenced
this pull request
Jul 16, 2020
* initial impl to fix issue #76 * close rows * use exec if table dosen`t have pk * trying to fix tests * more tests * add permissions on table test6 * more tests * fix asserts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#76