[WIP] Change Access Control verification #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marioidival
requested review from
avelino,
crgimenes,
gtsalles,
cassiobotaro,
heltonalves99 and
felipeweb
avelino
requested changes
Jan 24, 2017
marioidival
force-pushed
the
improvements/access-control-middleware
branch
from
66a2dd0
to
953ad06
Compare
Current coverage is 86.49% (diff: 100%)@@ master #80 diff @@
==========================================
Files 6 6
Lines 753 733 -20
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 650 634 -16
+ Misses 68 65 -3
+ Partials 35 34 -1
|
avelino
requested changes
Jan 24, 2017
| @@ -1,4 +1,4 @@ | |||
| package cmd | |||
| package middlewares | |||
There was a problem hiding this comment.
I don't think it's necessary to put the package name as a prefix middlewares_utils, used utils example. The name utils is not very good, we need to think of another name.
There was a problem hiding this comment.
I agree, middlewares_utils.go isn't good name, but utils.go makes sense
| next(rw, rq) | ||
| return | ||
| } | ||
|
|
There was a problem hiding this comment.
No rules to this, gofmt do nothing 🤔
There was a problem hiding this comment.
@marioidival https://play.golang.org/p/UbeaD8IQwe
click in Format
There was a problem hiding this comment.
sorry, not exist two line, my eyes must have confused
avelino
approved these changes
Jan 24, 2017
|
thank you @marioidival |
avelino
pushed a commit
that referenced
this pull request
Jul 16, 2020
* Create utils to middleware * Remove old permission verifications * Create middleware to AccessControl * Remove old permission verification in tables.go * Create package middleware * Change name of middlewares utils file
avelino
pushed a commit
that referenced
this pull request
Jul 16, 2020
* Create utils to middleware * Remove old permission verifications * Create middleware to AccessControl * Remove old permission verification in tables.go * Create package middleware * Change name of middlewares utils file
avelino
pushed a commit
that referenced
this pull request
Jul 16, 2020
* Create utils to middleware * Remove old permission verifications * Create middleware to AccessControl * Remove old permission verification in tables.go * Create package middleware * Change name of middlewares utils file
avelino
pushed a commit
that referenced
this pull request
Jul 16, 2020
* Create utils to middleware * Remove old permission verifications * Create middleware to AccessControl * Remove old permission verification in tables.go * Create package middleware * Change name of middlewares utils file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WIP] Looking for new way to test it.
In manual test the feature it's ok, but it's cool have test code guarantee.
I NEED HELP
#79, #75, #52