Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The playground wouldn't be required for production #1122

Closed
wants to merge 1 commit into from

Conversation

garhbod
Copy link
Contributor

@garhbod garhbod commented Jan 7, 2020

  • Added or updated tests
  • Added Docs for all relevant versions
  • Updated CHANGELOG.md

Changes

Breaking changes

@spawnia
Copy link
Collaborator

spawnia commented Jan 8, 2020

Thanks for your PR, i appreciate it.

I always have the Playground enabled anywhere, as i don't see any downsides to having it.

It is especially useful in test or staging environments. Since i try to keep those as close as possible to prod, i do not install dev dependencies there and require Playground in the regular dependencies.

Let's see what other people have to say about this, i would tend towards leaving the docs as is.

@lorado
Copy link
Collaborator

lorado commented Jan 8, 2020

Hm I am using an external App, currently Altair GraphQL Client. Anyway, I also think it is ok to install playground to normal dependencies. Even if you keep it dev only, it is possible to connect to you graphql endpoint using external clients.

@spawnia spawnia closed this Jan 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants