Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type hint StoresSubscription instead of implementation #1286

Merged
merged 2 commits into from Apr 13, 2020
Merged

Type hint StoresSubscription instead of implementation #1286

merged 2 commits into from Apr 13, 2020

Conversation

stayallive
Copy link
Collaborator

@stayallive stayallive commented Apr 13, 2020 •
edited

  • Added or updated tests
  • Added Docs for all relevant versions
  • Updated CHANGELOG.md

Changes

Instead of concrete implementation typehint the contract allowing us to replace it.

Breaking changes

None, unless SubscriptionRegistry->__construct was extended by the user.

@spawnia
Copy link
Collaborator

spawnia commented Apr 13, 2020

Agreed, well done!

@spawnia spawnia changed the title Type hint contract instead of implementation Type hint StoresSubscription instead of implementation Apr 13, 2020
@spawnia spawnia merged commit 28f3eaf into nuwave:master Apr 13, 2020
@stayallive stayallive deleted the subscription-improvements branch April 13, 2020 20:07
This was referenced Apr 13, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stayallive @spawnia