Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify usage with laravel sanctum, login / logout mutations #1458

Merged
merged 11 commits into from
Jul 17, 2020
Merged

docs: clarify usage with laravel sanctum, login / logout mutations #1458

merged 11 commits into from
Jul 17, 2020

Conversation

dlindenkreuz
Copy link
Contributor

@dlindenkreuz dlindenkreuz commented Jun 26, 2020

  • Added or updated tests
  • Documented user facing changes
  • Updated CHANGELOG.md

Changes

It's not obvious how to use Laravel Sanctum as a guard. This PR adds docs to clarify usage. Additionally, this PR covers login / logout mutations with an example, also in conjunction with Laravel Sanctum.

As discussed in #1406.

Breaking changes

none

@dlindenkreuz dlindenkreuz marked this pull request as draft June 26, 2020 08:45
Co-authored-by: Benedikt Franke <benedikt@franke.tech>
@dlindenkreuz dlindenkreuz marked this pull request as ready for review June 28, 2020 22:20
@dlindenkreuz dlindenkreuz requested a review from spawnia July 2, 2020 11:23
@spawnia
Copy link
Collaborator

spawnia commented Jul 2, 2020

@dlindenkreuz i will try out the suggested changes in https://github.com/nuwave/lighthouse-example and review once i find the time.

@spawnia spawnia added the docs Concerns the documentation label Jul 6, 2020
@spawnia
Copy link
Collaborator

spawnia commented Jul 6, 2020

There is substantial amounts of setup that needs to be in place when starting from a bare-bones GraphQL only configuration. Going from your guide, things worked pretty well, but there are also some rough edges that should be smoothed out.

Can you give me some feedback on nuwave/lighthouse-example#9, how can that be improved?

@spawnia
Copy link
Collaborator

spawnia commented Jul 17, 2020

Thanks @dlindenkreuz

@spawnia spawnia merged commit 31d2833 into nuwave:master Jul 17, 2020
@dlindenkreuz dlindenkreuz deleted the sanctum-docs branch July 18, 2020 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Concerns the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants