Allow JSON notation -> in column references for complex where conditions
#1864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spawnia
requested changes
May 27, 2021
added 6 commits
May 31, 2021 12:02
akyrey
force-pushed
the
fix-json-column-notation
branch
from
5c7eef7
to
aa2784a
Compare
|
Should I update anything in the documentation? |
|
Sorry for multiple pushes for Style CI |
spawnia
changed the title
spawnia
changed the title
-> in column references for complex where conditions
StyleCI has an option to download a patch. |
|
I saw you added a custom JSON type. It is not needed for purposes of this PR, but if you want to use one for your projects, I recommend https://github.com/mll-lab/graphql-php-scalars/blob/master/src/JSON.php Note that I strongly recommend using actual types when you know the contents (don't be lazy), only resort to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1863
Add a test to query inner JSON. This test also required defining a new Scalar type JSON (ref. https://gist.github.com/lorado/0519972d6fcf01f1aa5179d09eb6a315)
Changes
Edited regex to check column name validity
Breaking changes
No breaking changes