-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panic! #79
Labels
bug
Something isn't working
Comments
Full backtrace:
|
nuxeh
added a commit
that referenced
this issue
Jan 14, 2019
The bot has been running, with the exception of one panic (#79), for a number of months now, on a couple of different servers, so make this a release.
Closed
After some investigation, it seems that this might be an issue with upstream I have created an issue on Also, this seems to be a separate issue from #82 , which appears to have been fixed by updating |
nuxeh
added a commit
that referenced
this issue
Jan 18, 2019
Use a regular expression to check whether a URL contains unsafe characters, according to RFC1738 [1]. If it does, skip the token. This works around an upstream bug in `reqwest`, which may be fixed in due course, but since a URL is invalid if it contains unsafe characters, this seems like a valid check to include here. Fixes #79. [1] https://www.ietf.org/rfc/rfc1738.txt
nuxeh
added a commit
that referenced
this issue
Jan 18, 2019
Use a regular expression to check whether a URL contains unsafe characters, according to RFC1738 [1]. If it does, skip the token. This works around an upstream bug in `reqwest`, which may be fixed in due course, but since a URL is invalid if it contains unsafe characters, this seems like a valid check to include here. Fixes #79. [1] https://www.ietf.org/rfc/rfc1738.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: