Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash with URLs containing ^ #442

Closed
nuxeh opened this issue Jan 18, 2019 · 4 comments
Closed

Crash with URLs containing ^ #442

nuxeh opened this issue Jan 18, 2019 · 4 comments
Labels
bug This is bug! upstream Blocked: upstream. Depends on a dependency to make a change first.

Comments

@nuxeh
Copy link

nuxeh commented Jan 18, 2019

reqwest crashes with the following panic when given URLs containing the caret character:

thread 'reqwest-internal-sync-runtime' panicked at 'a parsed Url should always be a valid Uri: InvalidUri(InvalidUriChar)', libcore/result.rs:1009:5

Does this mean that clients of the crate should always check for unsafe characters before passing them to the library to avoid such panics?
@seanmonstar
Copy link
Owner

No, I believe such a panic is an actual bug in reqwest. I'll look into it.

@seanmonstar seanmonstar added the bug This is bug! label Jan 18, 2019
@nuxeh nuxeh mentioned this issue Jan 18, 2019
Closed
@seanmonstar seanmonstar added the upstream Blocked: upstream. Depends on a dependency to make a change first. label Jan 18, 2019
@seanmonstar seanmonstar mentioned this issue Feb 18, 2019
Merged
@seanmonstar
Copy link
Owner

This was fixed in http v0.1.16. Running cargo update -p http should fix anyone experiencing this.

nuxeh added a commit to nuxeh/url-bot-rs that referenced this issue Feb 19, 2019
@nuxeh
Update http 0.1.15 → 0.1.16
2986e3c 
This now includes upstream fixes for invalid characters in URLs.

seanmonstar/reqwest#442
nuxeh added a commit to nuxeh/url-bot-rs that referenced this issue Feb 20, 2019
@nuxeh
Update http 0.1.15 → 0.1.16
61ee860 
This now includes upstream fixes for invalid characters in URLs.

seanmonstar/reqwest#442
@mmacedoeu
Copy link

Got this today trying to install rust behind a proxy, is rustup-init using the right version ?

@seanmonstar
Copy link
Owner

@mmacedoeu looks like not, its lockfile sets http 0.1.13, before the fix.

@mmacedoeu mmacedoeu mentioned this issue Mar 13, 2019
Closed
@ZoeyR ZoeyR mentioned this issue Aug 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This is bug! upstream Blocked: upstream. Depends on a dependency to make a change first.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@seanmonstar @nuxeh @mmacedoeu