Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDOC-2184: subpages for Aspera Connector #1549

Merged
merged 13 commits into from Nov 16, 2020
Merged

Conversation

manonlumeau
Copy link
Contributor

No description provided.

@nuxeojenkins
Copy link

View issue in JIRA: NXDOC-2184: create doc structure for the aspera add-on

@lisamcintyre lisamcintyre marked this pull request as ready for review October 2, 2020 19:55
@lisamcintyre
Copy link
Contributor

lisamcintyre commented Oct 6, 2020

From @RSalem07: Since NXP-29548 and the merge that I did the last week, I forgot to tell you that you can:
remove or put in comment the two lines nuxeo.s3storage.useDirectUpload=true and nuxeo.s3storage.transient.roleArn in your nuxeo.conf
you can also remove the
export ASPERA_AWS_TRANSIENT_BUCKET_ROLE=arn:aws:iam::783725821734:role/l2it-test-gl-aspera-role from you bash profile / env variables , this one was needed to be able to run integration test on our local env against AWS.
I think we should update the documentation, to say that the role and useDirectUpload both of them are not needed.

@andreacornaglia
Copy link
Contributor

andreacornaglia commented Oct 8, 2020

Screen Shot 2020-10-08 at 11 26 45

Locally the layout seems to be breaking, not sure if it's because of the images or some markup hiccup or some local configuration on my side.

@manonlumeau
Copy link
Contributor Author

@andreacornaglia I'll take care of it, when doing my final review :)

Installation is made of two steps:

1. Install the [Nuxeo Package](https://connect.nuxeo.com/nuxeo/site/marketplace/package/nuxeo-aspera) available from the marketplace.
2. Install the [Aspera desktop client].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the idea to put a link here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreacornaglia yes, on the 2.0.x doc, there is a dead link. I need to locate a link to the connector that works and validate the version works with our connector.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Aspera desktop client is required but we don't recommend to do it outside our scope, or do we?
If you don't have it, you'll be prompted on the first time you try to use our connector/integration.

Also, the browser extension is also needed and we are not referring that. Guess we should decide what direction we want to take: state those things or document the wizard

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't NEED it, necessarily. It was part of the previous documentation. @nmpcunha , good point. I think it's actually a good idea to remove the link and just refer to the fact you will be "prompted to download the necessary software, if you haven't already installed it."


#### Transfer steps
The process of adding content is divided into 2 steps: **Upload** and **Create**.
In the first step, the user **uploads** content to the transfer bucket. While in this step, it may be possible, depending on the chosen “transition type”, for a user to add files to the bucket and add properties that will apply to the content.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to add files and folders


> The files uploaded by Aspera will be accessible in this folderish document (by default the target location is the user personal workspace)

Once on the Aspera Upload screen (as you begin to add files), you will be able to download the Aspera Desktop client via the following banner at the top (if not already installed or if a new version is needed):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe reword like, the first time using Aspera Upload, you will be prompt a dialog to install Aspera Desktop client....


- [Transfers Dashboard](#transfers-dashboard)

- [Transfers](#transfers)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid confusion, should we rename to something like Aspera Dashboard and Transfer View / Details ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreacornaglia good idea. we'll need to do something since, as we saw in the nike meeting, we'll want to really document what actions do and where they take you.

This screen shows the status of all current transfers in your Nuxeo application.

You can:
Create new uploads/transfers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obs: this needs markup to show as a list.

see [NXP-29282](https://jira.nuxeo.com/browse/nxp-29282)


### Storing message files
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we're already linking to the ticket, I would remove from the notes "check code", "code link", "check change".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

lisamcintyre and others added 3 commits October 12, 2020 13:31
We need to configure 2 Aspera nodes; one for upload and one for download.

Each node will be attached to one S3 bucket in Nuxeo:
- The main Nuxeo S3 bucket in Nuxeo for download purpose
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lisamcintyre , since it is related we should make sure about the download flow as discussed on slack. (i.e. Download will work without S3 Direct Upload?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmpcunha tested a download on master where the files were uploaded just using webui. It worked, so yes, we should be ok.

```
{{#> callout type='note'}}

Since the work in [NXP-29548](https://jira.nuxeo.com/browse/NXP-29548) 'nuxeo.s3storage.useDirectUpload=true' and 'nuxeo.s3storage.transient.roleArn=' (documented as part of the previous version configuration) are no longer necessary **for the Nuxeo Aspera Connector** and can be removed, **if you only use these values for the Nuxeo Aspera Connector, and not for any other reason**. See upgrade notes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it deserves a link also to the upgrade notes. WDYT?
BTW, please be aware that the ticket does not state any upgrade notes (cc @RSalem07)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PS: @lisamcintyre , this ticket is an internal one, so it won't be accessible 🤷🏼‍♂️

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmpcunha will work through the links (concerning the upgrade page AND the fact this ticket isn't viewable). will see what makes the most sense to point to for information. Thanks for pointing that out 👍

Comment on lines 174 to 185
aspera.node.url=https://ats-aws-us-east-1.aspera.io
aspera.node.port=443

### ACCESS KEY ON UPLOAD NODE LINKED TO TS S3 BUCKET
aspera.access.key.id=
### SECRET KEY ON UPLOAD NODE LINKED TO TS S3 BUCKET
aspera.access.key.secret=

### ACCESS KEY ON DOWNLOAD NODE LINKED TO TMAIN S3 BUCKET
aspera.download.access.key.id=
### SECRET KEY ON DOWNLOAD NODE LINKED TO MAIN S3 BUCKET
aspera.download.access.key.secret=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest that we could put values everywhere. Fake ones, or course.
Or simply don't put any value and leave everything empty as above for s3 configs.

Mixing both approaches doesn't make sense IMHO


#### Transfer steps
The process of adding content is divided into 2 steps: **Upload** and **Create**.
In the first step, the user **uploads** content to the transfer bucket. While in this step, it may be possible, depending on the chosen “transition type”, for a user to add files to the bucket and add properties that will apply to the content.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check, @andreacornaglia!

Suggested change
In the first step, the user **uploads** content to the transfer bucket. While in this step, it may be possible, depending on the chosen “transition type”, for a user to add files to the bucket and add properties that will apply to the content.
In the first step, the user **uploads** content to the transfer bucket. While in this step, it may be possible, depending on the chosen “transition type”, for a user to add files and folders to the bucket and add properties that will apply to the content.

Once content and any metadata have been added, the transfer can be completed and the content is then **created** in the system.

#### Transfer transition types
Transitioning between the “upload” and “create” steps can be achieved in 2 ways: **automatically (auto-create)** or **manually**. Users can choose which option to use when creating the transfer from the transfer dashboard. It is possible to change from manual to auto-create after you start adding content to the transfer. **Once you set the to auto-create, however, the transfer will behave as if you started in that way, and some limitations around modifying the transfer will apply**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the other way around, right? 🤔

Suggested change
Transitioning between the “upload” and “create” steps can be achieved in 2 ways: **automatically (auto-create)** or **manually**. Users can choose which option to use when creating the transfer from the transfer dashboard. It is possible to change from manual to auto-create after you start adding content to the transfer. **Once you set the to auto-create, however, the transfer will behave as if you started in that way, and some limitations around modifying the transfer will apply**.
Transitioning between the “upload” and “create” steps can be achieved in 2 ways: **automatically (auto-create)** or **manually**. Users can choose which option to use when creating the transfer from the transfer dashboard. It is **not** possible to change from manual to auto-create after you start adding content to the transfer. **Once you set the to auto-create, however, the transfer will behave as if you started in that way, and some limitations around modifying the transfer will apply**.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oy, thanks @nmpcunha that's why we have reviews...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmpcunha reading through this...it is as I originally wrote it...you can start with the transfer set to manually complete and keep it there after adding content OR, if you choose, once you started adding content, you can switch to autocreate, BUT from that point, any content you add will be your "last"; the transfer will complete upon THAT content being uploaded.

Copy link
Contributor

@nmpcunha nmpcunha Oct 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure If I understood your point, TBH 😕
This sentence doesn't seem clear to me: It is possible to change from manual to auto-create after you start adding content to the transfer.

Because we can't, right? Or am I missing something here? 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmpcunha I'm almost positive that we could at one time. I just tested though, and you're correct 😄 . at one time, I thought we had that so that if you had folders at different "root" locations in your finder/explorer, you could do part (grab one root), then change to auto and then get the other root location. I will modify the documentation 👍

#### Transfer transition types
Transitioning between the “upload” and “create” steps can be achieved in 2 ways: **automatically (auto-create)** or **manually**. Users can choose which option to use when creating the transfer from the transfer dashboard. It is possible to change from manual to auto-create after you start adding content to the transfer. **Once you set the to auto-create, however, the transfer will behave as if you started in that way, and some limitations around modifying the transfer will apply**.

When auto-create is toggled/selected to be “on”, the user needs only to start the upload of the folders/files to the transfer. Once the upload is completed, the system will automatically start the process to create the content in the system; no need to wait around simply to push a button. **Before adding content** to the transfer, you can edit the **“common metadata”** which would apply to all files in the transfer. Users can, of course, decide not to include any metadata at all, and simply add files, too.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency purposes should we use content or files and folders?

Suggested change
When auto-create is toggled/selected to be “on”, the user needs only to start the upload of the folders/files to the transfer. Once the upload is completed, the system will automatically start the process to create the content in the system; no need to wait around simply to push a button. **Before adding content** to the transfer, you can edit the **“common metadata”** which would apply to all files in the transfer. Users can, of course, decide not to include any metadata at all, and simply add files, too.
When auto-create is toggled/selected to be “on”, the user needs only to start the upload of the content to the transfer. Once the upload is completed, the system will automatically start the process to create the content in the system; no need to wait around simply to push a button. **Before adding content** to the transfer, you can edit the **“common metadata”** which would apply to all files in the transfer. Users can, of course, decide not to include any metadata at all, and simply add files, too.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to say let's use files and folders, but the more I think about it, "content" might be a better word; it's more inclusive of the various types of "stuff". By that, I mean, that since we should rely on the import/file manager and any business rules that apply for determining the "doc type", stating "files and folders" could be a little "limiting". sure, the content in the transfer is comprised of files and folders, but what they are once they get into the repo might be something that extends those types and not referred to as simply "file" or "folder".

If a user has content that needs to be “tagged” or “catalogued” with metadata before creation in the system, the “manual” transition option might be a better choice. To use the **manual option**, choose “no” for auto-create or toggle the auto-create to “off” when creating a new transfer (you can only turn off auto-create if there is **no content in the transfer)**. This will require someone **manually start** the creation process by clicking the **“complete transfer”** button once the upload is finished (the button is only visible once there is no longer an upload in progress)
When using the manual transition, the user uploads content to the transfer bucket. While in this step, a user can add folders and files to the bucket and add properties that apply to the files. Properties can be added that apply to all files using the “common metadata” panel; more file-specific properties can be added either to multiple files at once (bulk edit of metadata) and/or individually, using a single-file action.
Once the metadata has been edited to fit the user's needs, the transfer can be **completed** and the content is then created in the system.
Transfers have 3 states: Draft (no content added yet), In Progress (content added) and Completed (the transfer has been completed and the content has been created in the system).
Copy link
Contributor

@nmpcunha nmpcunha Oct 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More or less... 😅
We have more states, even visually. Right?

When we create a transfer it is on "draft".
When we are uploading files it says "Started".
When we press "complete" it would show "Pending".
When everything is done is says "Completed".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmpcunha more or less, but I don't believe we show the "draft" state anymore. we only show a status icon for started/pending/completed. showing the draft state was too confusing. this is the draft state (and on the dash, we just have the actions). Remember, this is just the "functional" info at this point. : )
Screen Shot 2020-10-13 at 3 21 46 PM

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, there is nothing right now stating "Draft", which may be also tricky from a functional perspective to state that.
Anyway, what does make sense to state as states from a "functional perspective"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering if we can summarise those scenarios in a given table,

it's mainly a suggestion / proposal but we can live with the description :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, will remove the reference to the "draft" state (since we don't visualize it) and focus on what we do see (pending/started/completed for now, I believe).. I think once we get our LC states redone for transfers, then a table will be the best way to summarize and can make it similar in "function" to the sheet we have on our wiki page and include manual/auto create info, too.


Once in your instance, Nuxeo Aspera Upload can be accessed from two different ways:

- From the **User Settings** menu located on the left side:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one goes to the dashboard

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"it depends". it goes to the last aspera view you were in. if I'm in a trnasfer (not on the dashboard) and then i go to the domain and browse, THEN go to the user settings/aspera dashboard, i land in the transfer I was last in (i just validated on master). not sure i that is was you were addressing here : )

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess it is a bug then and we should address 😅
If it says "Aspera Dashboard" it should direct the user to the dashboard 🤷🏼‍♂️

--}}
![aspera-image3](nx_asset://2a6ee847-e886-4047-8e82-f4cafda627eb ?border=true)

- By clicking on the Aspera upload button displayed on every folderish document (workspace, folder, etc.)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But this one will create a new transfer with the folderish as destination!

Do you think it worths to explain that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(As it was explained on line 296)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes! as we saw with nike call i did. Thanks for reminding me!


The Nuxeo Aspera Connector uses "Transfers" to add content to the system.

The process is divided into 2 steps: Upload and Create.

In the first step, the user **uploads** content to the transfer bucket. While in this step, he can add files to the bucket and add properties that will apply to the content. Properties can be added to all files at once (common metadata), to multiple files at once (bulk edit of metadata) and one at a time.
In the first step, the user **uploads** content to the transfer bucket. While in this step, a user can add content to the bucket and add properties that will apply to the content. Properties can be added to all files at once (common metadata), to multiple files at once (bulk edit of metadata) and one at a time.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version only allows files, right? Not sure if using content is clear enough since we use it above with a different meaning 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, thanks. I realized i got a little "find" edit happy within my doc pages after I got to a place where I saw a typo and said "I could swear I fixed that" and then i realized i was down in the 2.0.x area. I thought I backed out my changes. wil review. 👍

@@ -210,7 +585,7 @@ Once in your instance, Nuxeo Aspera Upload can be accessed from two different wa
--}}
![2-aspera.png](nx_asset://baeef2eb-ddbc-41e1-b036-46ee567027bf ?w=450,border=true)

> The files uploaded by Aspera will be accessible in this folderish document (by default the target location is the user personal workspace)
> The content uploaded by Aspera will be accessible in this folderish document (by default the target location is the user personal workspace)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question as above


This screen shows the status of all current transfers in your Nuxeo application.</br>

You can:
- Access the transfer metadata and files properties

- Access the transfer metadata and content's properties
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same files vs content question 😅



### Folder upload support
Now, in addition to files, users have the ability to upload content in folders as well as files. As with files, the upload/creation honors configurations of your file import manager and will apply document types and metadata based on your business rules.
Copy link
Contributor

@nmpcunha nmpcunha Oct 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be more clear? WDYT?

Suggested change
Now, in addition to files, users have the ability to upload content in folders as well as files. As with files, the upload/creation honors configurations of your file import manager and will apply document types and metadata based on your business rules.
Now, in addition to files, users have the ability to upload folders and their content as well as files. As with files, the upload/creation honors configurations of your file import manager and will apply document types and metadata based on your business rules.

For a listing of improvements and functional enhancements in version 3.0.x, please see the [release notes]() {{! /excerpt}}

{{#> callout type='warning'}}
Because of the changes to parameters in the nuxeo.conf file, this release is labeled as a major release. Transfers that exist in your system **that were started/created with a previous version will not work with this release and attempts to complete them will fail with this realse**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was not only due to the parameters change, but also to code/APIs changes.
Maybe it worths to refer that since then, below, we talk about them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...with this realse-> with this release

For a listing of improvements and functional enhancements in version 3.0.x, please see the [release notes]() {{! /excerpt}}

{{#> callout type='warning'}}
Because of the changes to parameters in the nuxeo.conf file, this release is labeled as a major release. Transfers that exist in your system **that were started/created with a previous version will not work with this release and attempts to complete them will fail with this realse**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Because of the changes to parameters in the nuxeo.conf file, this release is labeled as a major release. Transfers that exist in your system **that were started/created with a previous version will not work with this release and attempts to complete them will fail with this realse**.
Because of the changes to parameters in the **nuxeo.conf** file and also to some API's deprecation and major changes, this release is labeled as a major release. Transfers that exist in your system **that were started/created with a previous version will not work with this release and attempts to complete them will fail with this release**. It is recommended to don't update the Connector version with _ongoing_ transfers.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like your suggestion, but need to change the wording just a bit so can't commit suggestion directly 👍


### Requirements
- Aspera Desktop Client - [latest version]
- Nuxeo Server LTS 2019 (10.10, HF 31, at least) with access to AWS S3 Storage along with the [Amazon S3 Online Storage plugin](https://connect.nuxeo.com/nuxeo/site/marketplace/package/amazon-s3-online-storage?version=11.2.13)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess the amazon-s3-online-storage version is not the correct one. That's for 11.x or am I missing something?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guess the most up to date version for 10.10 would be 1.9.12

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i just did the link for the connector, I think it must grab the latest by default. will be sure to grab the specific one for 10. 👍

### Transfer edit
Removed `nuxeo-aspera-upload-edit-dialog` element

see [NXP-28207](https://jira.nuxeo.com/browse/nxp-28207
Copy link
Contributor

@nmpcunha nmpcunha Oct 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broken link!

Suggested change
see [NXP-28207](https://jira.nuxeo.com/browse/nxp-28207
see [NXP-28207](https://jira.nuxeo.com/browse/nxp-28207)

Co-authored-by: Nuno Cunha <ncunha@nuxeo.com>
@@ -14,24 +14,399 @@ tree_item_index: 1100

{{! excerpt}}
The [Nuxeo Aspera](https://connect.nuxeo.com/nuxeo/site/marketplace/package/nuxeo-aspera) connector
enables users to download/upload binaries with Aspera.
enables users to download/upload binaries with Aspera. It is designed to be used with **Aspera On Cloud** instances, however, if you use a **self-hosted Aspera** instance, it is still possible you will be able to use the Nuxeo Aspera Connector. Contact your Aspera team for more information and assistance.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering if we should or not :) add the Aspera link documentation to Aspera On Cloud

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RSalem07 good idea. would help us really "hit home" about the fact this is geared to AOC.


- Aspera Desktop Client - you will be prompted to install necessary versions when using the Connector.
- Nuxeo Server LTS 2019 (**10.10, HF 31, at least**) with access to AWS S3 Storage along with the [Amazon S3 Online Storage plugin](https://connect.nuxeo.com/nuxeo/site/marketplace/package/amazon-s3-online-storage?version=11.2.13)
- IBM Aspera on Cloud Subscription (see note above about Aspera self-hosted)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About Amazone S3 Online Storage I think we should give the link for the expected version for LTS 2019
https://connect.nuxeo.com/nuxeo/site/marketplace/package/amazon-s3-online-storage?version=1.9.12 instead of 11.2.13


{{#> callout type='warning'}}
If you are **upgrading from a previous version** of the Nuxeo Aspera connector, please see the [upgrade notes](https://doc.nuxeo.com/nxdoc/nuxeo-aspera-connector/nuxeo-aspera-upgrade-notes/) for critical information related to potential breaking code.
{{/callout}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release not is not yet available, isn't it ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not 3.0 but previous ones, yes.

Copy link
Contributor

@RSalem07 RSalem07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Lisa for the work, Left some comments / suggestions

lisamcintyre and others added 4 commits October 16, 2020 12:44
…lease-notes.md

Co-authored-by: Nuno Cunha <ncunha@nuxeo.com>
Co-authored-by: Salem Aouana <46494950+RSalem07@users.noreply.github.com>
@manonlumeau manonlumeau merged commit fd5d870 into 1010 Nov 16, 2020
@manonlumeau manonlumeau deleted the NXDOC-2184-aspera-doc branch November 16, 2020 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants