Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDOC-2221: update nuxeo-web-ui upgrade notes #1651

Merged
merged 4 commits into from
Jan 11, 2021

Conversation

richardsd
Copy link
Contributor

I've updated the Web UI upgrade notes, but I wonder if I should create a new file for it. Wdyt?
Reviews and feedback are very welcome :)

@nuxeojenkins
Copy link

View issue in JIRA: NXDOC-2221: Improve Web UI upgrade notes

Copy link
Contributor

@bchauvin bchauvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some suggestions, also I think we need to clarify a few things. We can work together on it if you want :)

@richardsd
Copy link
Contributor Author

Added some suggestions, also I think we need to clarify a few things. We can work together on it if you want :)

Thank you Bertrand. I left so comments as well, and we can discuss it further when you're available.

@richardsd richardsd force-pushed the NXDOC-2221-webui-upgrade-notes branch from d21dfbf to 1250cb7 Compare January 4, 2021 12:07
Copy link
Contributor

@bchauvin bchauvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided screenshots, the rest is 👍

bchauvin
bchauvin previously approved these changes Jan 6, 2021
@richardsd
Copy link
Contributor Author

Asked for another round of reviews due to some cleanup, images added and changes requested by @Gabez0r and @bchauvin 👍 Thank you all for the reviews

Copy link
Contributor

@bchauvin bchauvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment

@richardsd richardsd force-pushed the NXDOC-2221-webui-upgrade-notes branch from c3f435e to c6e97ca Compare January 7, 2021 17:04
bchauvin
bchauvin previously approved these changes Jan 8, 2021
Copy link
Contributor

@bchauvin bchauvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏 👏

Gabez0r
Gabez0r previously approved these changes Jan 11, 2021
@manonlumeau manonlumeau dismissed stale reviews from Gabez0r and bchauvin via 1fcf18d January 11, 2021 15:46
@manonlumeau manonlumeau merged commit bf75e4f into master Jan 11, 2021
@manonlumeau manonlumeau deleted the NXDOC-2221-webui-upgrade-notes branch January 11, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants