Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NXDOC-2301: update adobe authentication flow and ux improvements #1762

Merged
merged 2 commits into from Oct 25, 2021
Merged

NXDOC-2301: update adobe authentication flow and ux improvements #1762

merged 2 commits into from Oct 25, 2021

Conversation

manonlumeau
Copy link
Contributor

No description provided.

@nuxeojenkins
Copy link

View issue in JIRA: NXDOC-2301: update adobe connector doc

pddgoncalves
pddgoncalves reviewed Apr 8, 2021
View reviewed changes
Copy link

@pddgoncalves pddgoncalves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor suggestions 🙂 Thank you!

src/nxdoc/nuxeo-add-ons/nuxeo-for-adobe-cc.md Outdated Show resolved Hide resolved
src/nxdoc/nuxeo-add-ons/nuxeo-for-adobe-cc.md Outdated Show resolved Hide resolved
src/nxdoc/nuxeo-add-ons/nuxeo-for-adobe-cc.md Outdated Show resolved Hide resolved
src/nxdoc/nuxeo-add-ons/nuxeo-for-adobe-cc.md Show resolved Hide resolved
src/nxdoc/nuxeo-add-ons/nuxeo-for-adobe-cc.md Show resolved Hide resolved
lisamcintyre
lisamcintyre previously approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@lisamcintyre lisamcintyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manon, we are good to go with this branch. Can we also apply to other doc branches (same content)? I'm still waiting an update to the mp package though, so if the merge means the publish is "immediate" then please hold off for just a day or two.

Thanks
Lisa

pddgoncalves
pddgoncalves previously approved these changes Apr 13, 2021
View reviewed changes
pddgoncalves
pddgoncalves previously approved these changes Oct 22, 2021
View reviewed changes
@manonlumeau manonlumeau force-pushed the NXDOC-2301-update-adobe-authentication-flow-and-UX-improvements branch from b086195 to 1be5aa9 Compare October 25, 2021 14:01
@manonlumeau manonlumeau merged commit 3871fd0 into 2021 Oct 25, 2021
@manonlumeau manonlumeau deleted the NXDOC-2301-update-adobe-authentication-flow-and-UX-improvements branch October 25, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lisamcintyre lisamcintyre lisamcintyre left review comments

@pddgoncalves pddgoncalves pddgoncalves left review comments

Assignees
No one assigned
Labels
Reviewed Wait before merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@manonlumeau @nuxeojenkins @lisamcintyre @pddgoncalves