Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDOC-2498: added new documentation missing slots #2021

Merged

Conversation

poonamyadav252
Copy link
Contributor

Hi @bchauvin ,
cc: @manonlumeau

As we discussed I am going to open a PR for review and modification and it needs some changes with the label and description as well, Kindly have a look and suggested to me further changes in those new slots.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

src/nxdoc/web-ui/web-ui-tutorials/web-ui-slots.md Outdated Show resolved Hide resolved
src/nxdoc/web-ui/web-ui-tutorials/web-ui-slots.md Outdated Show resolved Hide resolved
src/nxdoc/web-ui/web-ui-tutorials/web-ui-slots.md Outdated Show resolved Hide resolved
src/nxdoc/web-ui/web-ui-tutorials/web-ui-slots.md Outdated Show resolved Hide resolved
src/nxdoc/web-ui/web-ui-tutorials/web-ui-slots.md Outdated Show resolved Hide resolved
src/nxdoc/web-ui/web-ui-tutorials/web-ui-slots.md Outdated Show resolved Hide resolved
src/nxdoc/web-ui/web-ui-tutorials/web-ui-slots.md Outdated Show resolved Hide resolved
src/nxdoc/web-ui/web-ui-tutorials/web-ui-slots.md Outdated Show resolved Hide resolved
@poonamyadav252 poonamyadav252 force-pushed the imp-NXDOC-2498-add-documentation-about-missing-slots branch 2 times, most recently from 8de1646 to 7f714ff Compare November 25, 2022 14:15
@poonamyadav252 poonamyadav252 force-pushed the imp-NXDOC-2498-add-documentation-about-missing-slots branch from 4bc8d7f to 0dae317 Compare November 25, 2022 14:24
Copy link
Contributor

@bchauvin bchauvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@manonlumeau manonlumeau merged commit 284a055 into 2021 Nov 28, 2022
@manonlumeau manonlumeau deleted the imp-NXDOC-2498-add-documentation-about-missing-slots branch November 28, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants