NXDRIVE-2322: Do not retry a HTTP call that failed on 500 error

[BoboTiG]

Retrying on HTTP 500 was leading to obscure issues when finalizing a transfer done via a third-party provider like S3.

[nuxeojenkins]

View issue in JIRA: NXDRIVE-2322: Do not retry a HTTP call that failed on 500 error

[sourcery-ai]

Sourcery Code Quality Report

This PR has an average code quality of 83.17%

Quality metrics	Before	After	Change
Complexity		1.87 ⭐
Method Length		44.15 ⭐
Working memory		7.19 🙂
Quality	%	83.17% ⭐	%

Other metrics	Before	After	Change
Lines		689

Changed files	Quality Before	Quality After	Quality Change
nxdrive/client/remote_client.py	%	83.17% ⭐	%

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
nxdrive/client/remote_client.py	Remote.download	8 ⭐	302 ⛔	20 ⛔	33.02% 😞	Try splitting into smaller methods. Extract out complex expressions
nxdrive/client/remote_client.py	Remote.transfer_end_callback	16 🙂	155 😞	14 😞	40.91% 😞	Try splitting into smaller methods. Extract out complex expressions
nxdrive/client/remote_client.py	Remote.__init__	5 ⭐	152 😞	19 ⛔	46.13% 😞	Try splitting into smaller methods. Extract out complex expressions
nxdrive/client/remote_client.py	Remote.get_fs_children	10 🙂	75 🙂	10 😞	62.89% 🙂	Extract out complex expressions
nxdrive/client/remote_client.py	Remote.get_info	5 ⭐	85 🙂	10 😞	66.16% 🙂	Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.