Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDRIVE-2339: Tell test_proxy.py to use a temporary folder instead of… #2089

Merged
merged 1 commit into from Oct 14, 2020

Conversation

BoboTiG
Copy link
Contributor

@BoboTiG BoboTiG commented Oct 14, 2020

… the current directory

Also fixed the ignored pattern for databases in WAL mode.

@nuxeojenkins
Copy link
Contributor

View issue in JIRA: NXDRIVE-2339: Tell test_proxy.py to use a temporary folder instead of the current directory

… the current directory

Also fixed the ignored pattern for databases in WAL mode.
@BoboTiG BoboTiG force-pushed the wip-NXDRIVE-2339-fix-test-proxy-tmp-file-leak branch from 067b421 to cb01318 Compare October 14, 2020 13:53
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 14, 2020

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.01%.

Quality metrics Before After Change
Complexity 0.08 ⭐ 0.08 ⭐ 0.00
Method Length 36.83 ⭐ 36.75 ⭐ -0.08 👍
Working memory 4.58 ⭐ 4.58 ⭐ 0.00
Quality 91.35% 91.36% 0.01% 👍
Other metrics Before After Change
Lines 109 108 -1
Changed files Quality Before Quality After Quality Change
tests/unit/test_proxy.py 91.35% ⭐ 91.36% ⭐ 0.01% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@BoboTiG BoboTiG merged commit cd54482 into master Oct 14, 2020
@BoboTiG BoboTiG deleted the wip-NXDRIVE-2339-fix-test-proxy-tmp-file-leak branch October 14, 2020 14:04
@BoboTiG BoboTiG added this to the 4.5.0 milestone Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants