Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDRIVE-2339: Tell test_proxy.py to use a temporary folder instead of… #2089

Merged
merged 1 commit into from Oct 14, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
Expand Up @@ -8,7 +8,7 @@ cover
coverage
.coverage*
*.db-shm
*.db-wall
*.db-wal
debian
dist
dist-beta
Expand Down
1 change: 1 addition & 0 deletions docs/changes/4.4.6.md
Expand Up @@ -35,6 +35,7 @@ Release date: `2020-xx-xx`

- [NXDRIVE-2316](https://jira.nuxeo.com/browse/NXDRIVE-2316): Skip the synchronization in the auto-update check script
- [NXDRIVE-2326](https://jira.nuxeo.com/browse/NXDRIVE-2326): Fix test `test_get_metadata_infos()`
- [NXDRIVE-2339](https://jira.nuxeo.com/browse/NXDRIVE-2339): Tell `test_proxy.py` to use a temporary folder instead of the current directory

## Docs

Expand Down
6 changes: 2 additions & 4 deletions tests/unit/test_proxy.py
@@ -1,5 +1,3 @@
# coding: utf-8
from pathlib import Path
from unittest.mock import patch

import pytest
Expand Down Expand Up @@ -33,8 +31,8 @@ def js():


@pytest.fixture()
def config_dao():
db = Path("tmp.db")
def config_dao(tmp_path):
db = tmp_path / "tmp.db"
dao = ConfigurationDAO(db)
yield dao
dao.dispose()
Expand Down