Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDRIVE-2393: Display a proper error message when the nuxeo-drive add… #2181

Merged
merged 2 commits into from
Nov 16, 2020

Conversation

BoboTiG
Copy link
Contributor

@BoboTiG BoboTiG commented Nov 16, 2020

…on is not installed on the server

@nuxeojenkins
Copy link
Contributor

View issue in JIRA: NXDRIVE-2393: Display a proper error message when the nuxeo-drive addon is not installed on the server

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 16, 2020

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.05%.

Quality metrics Before After Change
Complexity 4.76 ⭐ 4.78 ⭐ 0.02 👎
Method Length 41.52 ⭐ 41.62 ⭐ 0.10 👎
Working memory 7.79 🙂 7.78 🙂 -0.01 👍
Quality 73.81% 🙂 73.76% 🙂 -0.05% 👎
Other metrics Before After Change
Lines 3139 3156 17
Changed files Quality Before Quality After Quality Change
nxdrive/exceptions.py 99.06% ⭐ 99.01% ⭐ -0.05% 👎
nxdrive/manager.py 70.23% 🙂 70.14% 🙂 -0.09% 👎
nxdrive/engine/engine.py 72.08% 🙂 72.01% 🙂 -0.07% 👎
nxdrive/gui/api.py 75.69% ⭐ 75.61% ⭐ -0.08% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
nxdrive/manager.py Manager.__init__ 26 😞 443 ⛔ 10 😞 28.84% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
nxdrive/gui/api.py QMLDriveApi.bind_server 16 🙂 221 ⛔ 16 ⛔ 33.07% 😞 Try splitting into smaller methods. Extract out complex expressions
nxdrive/manager.py Manager.bind_engine 15 🙂 233 ⛔ 13 😞 36.94% 😞 Try splitting into smaller methods. Extract out complex expressions
nxdrive/engine/engine.py Engine.bind 14 🙂 191 😞 12 😞 42.25% 😞 Try splitting into smaller methods. Extract out complex expressions
nxdrive/engine/engine.py Engine._check_last_sync 7 ⭐ 154 😞 19 ⛔ 43.99% 😞 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@BoboTiG BoboTiG merged commit 068e685 into master Nov 16, 2020
@BoboTiG BoboTiG deleted the NXDRIVE-2393-addon-not-installer-error-msg branch November 16, 2020 15:37
@BoboTiG BoboTiG added this to the 4.5.0 milestone Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants