Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDRIVE-2489: [Windows] Subfolder content not synced on unfiltering #2416

Merged
merged 5 commits into from
Jan 26, 2021

Conversation

rom1win
Copy link
Contributor

@rom1win rom1win commented Jan 26, 2021

No description provided.

@nuxeojenkins
Copy link
Contributor

View issue in JIRA: NXDRIVE-2489: [Windows] Subfolder content not synced on unfiltering

@rom1win rom1win force-pushed the wip-NXDRIVE-2489-fix-register-adapter branch from a8d32db to 3465580 Compare January 26, 2021 15:01
tests/unit/test_engine_dao.py Outdated Show resolved Hide resolved
tests/unit/test_engine_dao.py Outdated Show resolved Hide resolved
tests/unit/test_engine_dao.py Outdated Show resolved Hide resolved
tests/unit/test_engine_dao.py Outdated Show resolved Hide resolved
@rom1win rom1win force-pushed the wip-NXDRIVE-2489-fix-register-adapter branch from e74c793 to bd46559 Compare January 26, 2021 16:00
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 26, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.13%.

Quality metrics Before After Change
Complexity 1.21 ⭐ 1.22 ⭐ 0.01 👎
Method Length 49.85 ⭐ 50.42 ⭐ 0.57 👎
Working memory 7.48 🙂 7.54 🙂 0.06 👎
Quality 78.07% 77.94% -0.13% 👎
Other metrics Before After Change
Lines 949 999 50
Changed files Quality Before Quality After Quality Change
nxdrive/engine/dao/sqlite.py 80.00% ⭐ 80.00% ⭐ 0.00%
tests/unit/test_engine_dao.py 76.18% ⭐ 76.07% ⭐ -0.11% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
nxdrive/engine/dao/sqlite.py EngineDAO.get_dt_uploads_raw 3 ⭐ 77 🙂 26 ⛔ 54.55% 🙂 Extract out complex expressions
nxdrive/engine/dao/sqlite.py EngineDAO.get_completed_sessions_raw 0 ⭐ 71 🙂 31 ⛔ 57.55% 🙂 Extract out complex expressions
tests/unit/test_engine_dao.py test_configuration_get_bool 0 ⭐ 292 ⛔ 8 🙂 57.75% 🙂 Try splitting into smaller methods
nxdrive/engine/dao/sqlite.py EngineDAO.get_active_sessions_raw 0 ⭐ 68 🙂 30 ⛔ 58.14% 🙂 Extract out complex expressions
nxdrive/engine/dao/sqlite.py EngineDAO.get_dt_uploads 2 ⭐ 67 🙂 19 ⛔ 60.20% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@@ -423,6 +423,7 @@ def test_migration_db_v16(engine_dao):
assert session.planned_items == 1


@windows_only
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rom1win rom1win added the bugfix label Jan 26, 2021
@rom1win rom1win marked this pull request as ready for review January 26, 2021 16:41
@BoboTiG BoboTiG merged commit a3a28fe into master Jan 26, 2021
@BoboTiG BoboTiG deleted the wip-NXDRIVE-2489-fix-register-adapter branch January 26, 2021 16:42
@BoboTiG BoboTiG added this to the 4.5.1 milestone Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants