Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDRIVE-2546: Use os.scandir() in the local watcher to improve perfor… #2513

Closed
wants to merge 1 commit into from

Conversation

BoboTiG
Copy link
Contributor

@BoboTiG BoboTiG commented Mar 1, 2021

…mances

@nuxeojenkins
Copy link
Contributor

View issue in JIRA: NXDRIVE-2546: Use os.scandir() in the local watcher to improve performances

@BoboTiG BoboTiG force-pushed the wip-NXDRIVE-2546-scandir-local-watcher branch from 9b8696f to 84c9ee3 Compare March 1, 2021 16:33
@BoboTiG BoboTiG force-pushed the wip-NXDRIVE-2546-scandir-local-watcher branch from 84c9ee3 to 37802cf Compare March 1, 2021 16:34
@BoboTiG BoboTiG closed this Mar 1, 2021
@BoboTiG BoboTiG deleted the wip-NXDRIVE-2546-scandir-local-watcher branch March 1, 2021 18:21
@BoboTiG BoboTiG restored the wip-NXDRIVE-2546-scandir-local-watcher branch March 1, 2021 18:21
@BoboTiG BoboTiG reopened this Mar 1, 2021
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 1, 2021

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 1.21 ⭐ 1.21 ⭐ 0.00
Method Length 26.27 ⭐ 26.27 ⭐ 0.00
Working memory 5.68 ⭐ 5.68 ⭐ 0.00
Quality 89.01% 89.01% 0.00%
Other metrics Before After Change
Lines 99 99 0
Changed files Quality Before Quality After Quality Change
nxdrive/client/local/base.py 89.01% ⭐ 89.01% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
nxdrive/client/local/base.py FileInfo.__repr__ 0 ⭐ 36 ⭐ 16 ⛔ 69.76% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@BoboTiG BoboTiG closed this Mar 1, 2021
@BoboTiG BoboTiG deleted the wip-NXDRIVE-2546-scandir-local-watcher branch March 1, 2021 18:28
@BoboTiG BoboTiG added this to the 5.1.0 milestone Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants