Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDRIVE-2550: Prevent Sentry flooding #2519

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

BoboTiG
Copy link
Contributor

@BoboTiG BoboTiG commented Mar 3, 2021

Added a simple filter to ignore already sent events.

I also removed the sensitive data redaction as it was not working and Sentry already provides such mechanism by default.

Added a simple filter to ignore already sent events.

I also removed the sensitive data redaction as it was not working
and Sentry already provides such mechanism by default.
@nuxeojenkins
Copy link
Contributor

View issue in JIRA: NXDRIVE-2550: Prevent Sentry flooding

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 3, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 4.41%.

Quality metrics Before After Change
Complexity 5.50 ⭐ 6.67 ⭐ 1.17 👎
Method Length 51.00 ⭐ 49.67 ⭐ -1.33 👍
Working memory 12.14 😞 12.52 😞 0.38 👎
Quality 60.40% 🙂 55.99% 🙂 -4.41% 👎
Other metrics Before After Change
Lines 97 67 -30
Changed files Quality Before Quality After Quality Change
nxdrive/main.py 60.40% 🙂 55.99% 🙂 -4.41% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
nxdrive/main.py main 7 ⭐ 124 😞 13 😞 53.79% 🙂 Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@BoboTiG BoboTiG merged commit 65fe7c9 into master Mar 3, 2021
@BoboTiG BoboTiG deleted the wip-NXDRIVE-2550-prevent-sentry-flooding branch March 3, 2021 17:22
@BoboTiG BoboTiG added this to the 5.1.0 milestone Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants