Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDRIVE-2581: Ask for restart when the synchronization feature state is updated #2636

Merged

Conversation

rom1win
Copy link
Contributor

@rom1win rom1win commented Apr 23, 2021

No description provided.

@nuxeojenkins
Copy link
Contributor

View issue in JIRA: NXDRIVE-2581: Add the synchronization feature

@codecov
Copy link

codecov bot commented Apr 23, 2021

Codecov Report

Merging #2636 (059e02e) into master (609c078) will decrease coverage by 0.01%.
The diff coverage is 18.18%.

❗ Current head 059e02e differs from pull request most recent head 4d08022. Consider uploading reports for the commit 4d08022 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2636      +/-   ##
==========================================
- Coverage   43.48%   43.47%   -0.02%     
==========================================
  Files          77       77              
  Lines       14632    14641       +9     
==========================================
+ Hits         6363     6365       +2     
- Misses       8269     8276       +7     
Flag Coverage Δ
functional 34.37% <18.18%> (-0.01%) ⬇️
integration 1.13% <0.00%> (-0.01%) ⬇️
unit 34.25% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
nxdrive/feature.py 100.00% <ø> (ø)
nxdrive/gui/application.py 0.00% <0.00%> (ø)
nxdrive/gui/view.py 0.00% <0.00%> (ø)
nxdrive/poll_workers.py 74.15% <66.66%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 609c078...4d08022. Read the comment docs.

@rom1win rom1win force-pushed the wip-NXDRIVE-2581-ask-for-restart-when-updating-feature-state branch from eac0eab to 059e02e Compare April 23, 2021 14:04
@rom1win rom1win marked this pull request as ready for review April 23, 2021 14:04
docs/changes/5.1.2.md Outdated Show resolved Hide resolved
Co-authored-by: Mickaël Schoentgen <mschoentgen@nuxeo.com>
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Apr 23, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.26%.

Quality metrics Before After Change
Complexity 4.73 ⭐ 5.02 ⭐ 0.29 👎
Method Length 49.45 ⭐ 49.20 ⭐ -0.25 👍
Working memory 8.65 🙂 8.65 🙂 0.00
Quality 67.77% 🙂 67.51% 🙂 -0.26% 👎
Other metrics Before After Change
Lines 1128 1141 13
Changed files Quality Before Quality After Quality Change
nxdrive/feature.py 94.51% ⭐ 94.51% ⭐ 0.00%
nxdrive/poll_workers.py 49.59% 😞 46.83% 😞 -2.76% 👎
nxdrive/gui/application.py 65.95% 🙂 65.95% 🙂 0.00%
nxdrive/gui/view.py 95.28% ⭐ 95.42% ⭐ 0.14% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
nxdrive/poll_workers.py ServerOptionsUpdater._poll 30 😞 239 ⛔ 13 😞 26.79% 😞 Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
nxdrive/gui/application.py Application.init_gui 5 ⭐ 533 ⛔ 14 😞 38.51% 😞 Try splitting into smaller methods. Extract out complex expressions
nxdrive/gui/application.py Application.change_systray_icon 9 🙂 135 😞 12 😞 52.16% 🙂 Try splitting into smaller methods. Extract out complex expressions
nxdrive/gui/application.py Application._wrong_channel 5 ⭐ 130 😞 13 😞 55.00% 🙂 Try splitting into smaller methods. Extract out complex expressions
nxdrive/gui/application.py Application.__init__ 4 ⭐ 264 ⛔ 7 🙂 57.24% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@BoboTiG BoboTiG merged commit 6b199ba into master Apr 23, 2021
@BoboTiG BoboTiG deleted the wip-NXDRIVE-2581-ask-for-restart-when-updating-feature-state branch April 23, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants