Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDRIVE-2623: Ignore RuntimeError: wrapped C/C++ object of type Queue… #2658

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

rom1win
Copy link
Contributor

@rom1win rom1win commented Apr 29, 2021

…Manager has been deleted in QueueManager.push_error()

Co-authored-by: Mickaël Schoentgen mschoentgen@nuxeo.com

…Manager has been deleted in QueueManager.push_error()

Co-authored-by: Mickaël Schoentgen <mschoentgen@nuxeo.com>
@nuxeojenkins
Copy link
Contributor

View issue in JIRA: NXDRIVE-2623: Ignore RuntimeError: wrapped C/C++ object of type QueueManager has been deleted in QueueManager.push_error()

@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Apr 29, 2021

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics Before After Change
Complexity 5.44 ⭐ 5.44 ⭐ 0.00
Method Length 40.79 ⭐ 40.79 ⭐ 0.00
Working memory 6.26 🙂 6.26 🙂 0.00
Quality 79.17% 79.17% 0.00%
Other metrics Before After Change
Lines 291 291 0
Changed files Quality Before Quality After Quality Change
nxdrive/engine/queue_manager.py 79.17% ⭐ 79.17% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
nxdrive/engine/queue_manager.py QueueManager.launch_processors 16 🙂 164 😞 9 🙂 48.69% 😞 Try splitting into smaller methods
nxdrive/engine/queue_manager.py QueueManager.get_metrics 0 ⭐ 86 🙂 26 ⛔ 56.22% 🙂 Extract out complex expressions
nxdrive/engine/queue_manager.py QueueManager.is_active 0 ⭐ 30 ⭐ 10 😞 79.75% ⭐ Extract out complex expressions
nxdrive/engine/queue_manager.py QueueItem.__repr__ 0 ⭐ 24 ⭐ 10 😞 80.74% ⭐ Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

@rom1win rom1win requested a review from BoboTiG April 29, 2021 14:22
@BoboTiG BoboTiG merged commit ebaff44 into master Apr 29, 2021
@BoboTiG BoboTiG deleted the wip-NXDRIVE-2623-ignore-runtime-error branch April 29, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants