NXDRIVE-2748: Review Auto Update Install latest update behavior

[mr-shekhar]

No description provided.

[nuxeojenkins]

View issues in JIRA:

• NXDRIVE-2748: Review Auto-Update/Install latest update behavior

[codecov]

Codecov Report

Merging #3321 (25b50e3) into master (247992b) will increase coverage by 0.04%.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##           master    #3321      +/-   ##
==========================================
+ Coverage   45.07%   45.12%   +0.04%     
==========================================
  Files          92       92              
  Lines       15422    15426       +4     
==========================================
+ Hits         6952     6961       +9     
+ Misses       8470     8465       -5     

Flag	Coverage Δ
functional	35.72% <20.00%> (+0.04%)	⬆️
integration	1.17% <20.00%> (+<0.01%)	⬆️
unit	35.49% <20.00%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
nxdrive/gui/api.py	0.00% <0.00%> (ø)
nxdrive/feature.py	100.00% <100.00%> (ø)
nxdrive/manager.py	67.68% <0.00%> (+0.05%)	⬆️
nxdrive/dao/engine.py	60.00% <0.00%> (+0.10%)	⬆️
nxdrive/engine/engine.py	58.62% <0.00%> (+0.11%)	⬆️
nxdrive/updater/base.py	75.64% <0.00%> (+0.42%)	⬆️
nxdrive/client/remote_client.py	41.91% <0.00%> (+0.49%)	⬆️
nxdrive/osi/darwin/darwin.py	50.73% <0.00%> (+0.97%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c3d7ad...25b50e3. Read the comment docs.

[mr-shekhar]

@dependabot rebase

[sourcery-ai]

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.27%.

Quality metrics	Before	After	Change
Complexity	2.60 ⭐	2.54 ⭐	-0.06 👍
Method Length	44.26 ⭐	44.22 ⭐	-0.04 👍
Working memory	6.34 🙂	6.41 🙂	0.07 👎
Quality	78.39% ⭐	78.12% ⭐	-0.27% 👎

Other metrics	Before	After	Change
Lines	1801	1846	45

Changed files	Quality Before	Quality After	Quality Change
nxdrive/feature.py	94.51% ⭐	93.69% ⭐	-0.82% 👎
nxdrive/gui/api.py	74.58% 🙂	74.50% 🙂	-0.08% 👎
tests/functional/test_server_options.py	73.19% 🙂	73.19% 🙂	0.00%
tests/functional/test_updater.py	90.14% ⭐	85.59% ⭐	-4.55% 👎
tests/unit/test_options.py	86.31% ⭐	86.31% ⭐	0.00%

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
nxdrive/gui/api.py	QMLDriveApi.bind_server	17 🙂	230 ⛔	12 😞	37.09% 😞	Try splitting into smaller methods. Extract out complex expressions
nxdrive/gui/api.py	QMLDriveApi.web_authentication	17 🙂	183 😞	10 😞	44.11% 😞	Try splitting into smaller methods. Extract out complex expressions
nxdrive/gui/api.py	QMLDriveApi.continue_oauth2_flow	11 🙂	179 😞	11 😞	47.60% 😞	Try splitting into smaller methods. Extract out complex expressions
tests/functional/test_server_options.py	test_features	0 ⭐	274 ⛔	11 😞	52.28% 🙂	Try splitting into smaller methods. Extract out complex expressions
nxdrive/gui/api.py	QMLDriveApi.update_token	6 ⭐	120 😞	12 😞	56.82% 🙂	Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

• ⭐ excellent
• 🙂 good
• 😞 poor
• ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

---

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!