New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ELEMENTS-1281: handle errors on bulk action #345
ELEMENTS-1281: handle errors on bulk action #345
Conversation
View issue in JIRA: ELEMENTS-1281: Add Errors handler for Nuxeo Operation |
8a0a538
to
9e02258
Compare
9e02258
to
907d503
Compare
1e4b8f1
to
4b281c7
Compare
d9a0050
to
5708e8b
Compare
@Gabez0r as asked the WEB-UI pipeline with this Element branch is launched: https://qa.nuxeo.org/jenkins/job/master/job/web-ui-pipeline/349/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me 👍
thanks @RSalem07 clearly we have a lot of margin for improvement when it comes to error handling but I'm not a big fan of explicitly stopping error propagation on each element so I'd rather we spent some time figuring out a better, more holistic, approach to the problem. |
Hey @nelsonsilva :) For now the one that needs this improvement is mainly the retention add-on. I have opened a PR nuxeo/nuxeo-retention#42
ah I see your point, my initial idea was to keep the same logic then the others (start pooling...) thx |
5708e8b
to
ffa6848
Compare
@nelsonsilva following our discussion, I have reverted the stop propagation error. I kept the update for a better error handling. please note that this PR is related to the backend one PR#4606. I have also update the retention one to use a simple Thx, |
new Jenkins build on WEB-UI https://qa.nuxeo.org/jenkins/job/master/job/web-ui-pipeline/354/ -> OK |
I updated the requirements, This PR depends now on the platform one PR#4606
**Note for the reviewers ** :)
Initially I have used the
error
event name, Here But I got some errors on the unit tests, mainly on thenuxeo-audit-page-provider.test.js
where the two tests below failed:Should fire an event when an error occurs in the Operation call
andShould return an error when occurs in the Operation call
as they expect to get thenotify
event, but it failed. That's the main reason why I have changed the name tofailure
, before that I have tried different approche to try to fix it by keeping theerror
event name. Finally I used thefailure
let me know wdytthx