Improvement nxp 30097 error handling async operation adapter #4606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View issue in JIRA: NXP-30097: Improve the error handling on Async Operation |
This was referenced Jan 26, 2021
nelsonsilva
reviewed
Jan 26, 2021
...rver/src/main/java/org/nuxeo/ecm/automation/server/jaxrs/adapters/AsyncOperationAdapter.java
Outdated
Show resolved
Hide resolved
ataillefer
reviewed
Jan 26, 2021
...ation-test/src/test/java/org/nuxeo/ecm/automation/server/test/AsyncOperationAdapterTest.java
Outdated
Show resolved
Hide resolved
RSalem07
force-pushed
the
improvement-NXP-30097-error-handling-async-operation-adapter
branch
from
f7602fe
to
2da20fe
Compare
ataillefer
reviewed
Jan 28, 2021
modules/core/nuxeo-core-api/src/main/java/org/nuxeo/ecm/core/api/AsyncStatus.java
Outdated
Show resolved
Hide resolved
RSalem07
force-pushed
the
improvement-NXP-30097-error-handling-async-operation-adapter
branch
from
2da20fe
to
2b1d47a
Compare
ataillefer
previously approved these changes
Jan 28, 2021
nelsonsilva
reviewed
Feb 1, 2021
...rver/src/main/java/org/nuxeo/ecm/automation/server/jaxrs/adapters/AsyncOperationAdapter.java
Outdated
Show resolved
Hide resolved
...ation-test/src/test/java/org/nuxeo/ecm/automation/server/test/AsyncOperationAdapterTest.java
Outdated
Show resolved
Hide resolved
RSalem07
force-pushed
the
improvement-NXP-30097-error-handling-async-operation-adapter
branch
from
2b1d47a
to
6824081
Compare
nelsonsilva
previously approved these changes
Feb 2, 2021
RSalem07
force-pushed
the
improvement-NXP-30097-error-handling-async-operation-adapter
branch
from
6824081
to
6ac54f2
Compare
|
#4659, which is has many changes around error management, also touches some of the same classes. Please wait for it to be merge before rebasing this on it and checking all tests still pass. |
|
@efge thx, I'll wait :) |
RSalem07
force-pushed
the
improvement-NXP-30097-error-handling-async-operation-adapter
branch
from
6ac54f2
to
00bc07d
Compare
efge
reviewed
Mar 17, 2021
...rver/src/main/java/org/nuxeo/ecm/automation/server/jaxrs/adapters/AsyncOperationAdapter.java
Outdated
Show resolved
Hide resolved
RSalem07
force-pushed
the
improvement-NXP-30097-error-handling-async-operation-adapter
branch
from
00bc07d
to
06ebaf7
Compare
efge
requested changes
Mar 18, 2021
...rver/src/main/java/org/nuxeo/ecm/automation/server/jaxrs/adapters/AsyncOperationAdapter.java
Outdated
Show resolved
Hide resolved
modules/core/nuxeo-core-api/src/main/java/org/nuxeo/ecm/core/api/AsyncStatus.java
Outdated
Show resolved
Hide resolved
...ation-test/src/test/java/org/nuxeo/ecm/automation/server/test/AsyncOperationAdapterTest.java
Outdated
Show resolved
Hide resolved
...rver/src/main/java/org/nuxeo/ecm/automation/server/jaxrs/adapters/AsyncOperationAdapter.java
Outdated
Show resolved
Hide resolved
RSalem07
force-pushed
the
improvement-NXP-30097-error-handling-async-operation-adapter
branch
3 times, most recently
from
96b7e5d
to
a382f43
Compare
RSalem07
force-pushed
the
improvement-NXP-30097-error-handling-async-operation-adapter
branch
from
a382f43
to
fd8085f
Compare
ataillefer
reviewed
Mar 22, 2021
modules/core/nuxeo-core-bulk/src/main/java/org/nuxeo/ecm/core/bulk/message/BulkStatus.java
Outdated
Show resolved
Hide resolved
modules/core/nuxeo-core-test/src/test/java/org/nuxeo/ecm/core/bulk/TestBulkProcessor.java
Outdated
Show resolved
Hide resolved
efge
requested changes
Mar 22, 2021
...xeo-core-bulk/src/main/java/org/nuxeo/ecm/core/bulk/computation/BulkScrollerComputation.java
Outdated
Show resolved
Hide resolved
modules/core/nuxeo-core-bulk/src/main/java/org/nuxeo/ecm/core/bulk/message/BulkStatus.java
Outdated
Show resolved
Hide resolved
modules/core/nuxeo-core-bulk/src/main/java/org/nuxeo/ecm/core/bulk/message/BulkStatus.java
Outdated
Show resolved
Hide resolved
modules/core/nuxeo-core-bulk/src/main/java/org/nuxeo/ecm/core/bulk/message/BulkStatus.java
Show resolved
Hide resolved
RSalem07
force-pushed
the
improvement-NXP-30097-error-handling-async-operation-adapter
branch
2 times, most recently
from
19db860
to
ac3e56a
Compare
efge
previously approved these changes
Mar 25, 2021
troger
reviewed
Mar 25, 2021
modules/core/nuxeo-core-api/src/main/java/org/nuxeo/ecm/core/api/AsyncStatus.java
Outdated
Show resolved
Hide resolved
kevinleturc
requested changes
Mar 25, 2021
modules/core/nuxeo-core-api/src/main/java/org/nuxeo/ecm/core/api/AsyncStatus.java
Outdated
Show resolved
Hide resolved
...xeo-core-bulk/src/main/java/org/nuxeo/ecm/core/bulk/computation/BulkScrollerComputation.java
Outdated
Show resolved
Hide resolved
...xeo-core-bulk/src/main/java/org/nuxeo/ecm/core/bulk/computation/BulkScrollerComputation.java
Outdated
Show resolved
Hide resolved
modules/core/nuxeo-core-bulk/src/main/java/org/nuxeo/ecm/core/bulk/message/BulkStatus.java
Outdated
Show resolved
Hide resolved
modules/core/nuxeo-core-bulk/src/main/java/org/nuxeo/ecm/core/bulk/message/BulkStatus.java
Outdated
Show resolved
Hide resolved
modules/core/nuxeo-core-bulk/src/main/java/org/nuxeo/ecm/core/bulk/message/BulkStatus.java
Show resolved
Hide resolved
RSalem07
force-pushed
the
improvement-NXP-30097-error-handling-async-operation-adapter
branch
from
ac3e56a
to
9fb55dc
Compare
RSalem07
force-pushed
the
improvement-NXP-30097-error-handling-async-operation-adapter
branch
from
9fb55dc
to
c7904c8
Compare
kevinleturc
reviewed
Apr 2, 2021
modules/core/nuxeo-core-bulk/src/main/java/org/nuxeo/ecm/core/bulk/message/BulkStatus.java
Outdated
Show resolved
Hide resolved
...xeo-core-bulk/src/main/java/org/nuxeo/ecm/core/bulk/computation/BulkScrollerComputation.java
Outdated
Show resolved
Hide resolved
modules/core/nuxeo-core-bulk/src/main/java/org/nuxeo/ecm/core/bulk/message/BulkStatus.java
Outdated
Show resolved
Hide resolved
RSalem07
force-pushed
the
improvement-NXP-30097-error-handling-async-operation-adapter
branch
from
c7904c8
to
7ee0c47
Compare
kevinleturc
reviewed
Apr 2, 2021
...xeo-core-bulk/src/main/java/org/nuxeo/ecm/core/bulk/computation/BulkScrollerComputation.java
Outdated
Show resolved
Hide resolved
RSalem07
force-pushed
the
improvement-NXP-30097-error-handling-async-operation-adapter
branch
from
7ee0c47
to
85581e1
Compare
kevinleturc
approved these changes
Apr 2, 2021
ataillefer
approved these changes
Apr 6, 2021
RSalem07
deleted the
improvement-NXP-30097-error-handling-async-operation-adapter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are required by the initial PR ELEMENTS#345, and the need on retention to manage the errors. As discussed it with Nelson, I have updated the backend part to throw an exception in a case where we face any issue with the bulk action, even completed.