ELEMENTS-1554: improve contrast for select all action #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poonamyadav252
requested review from
swarnadipa-dev,
Pranit-Sotre,
GuruprasadAnk1996,
Nisha-QA,
Nishant0928,
rajatgoel-gl,
richardsd,
semisse and
rakeshkumar1019
| background-color: var(--nuxeo-checkmark-background-color, transparent); | ||
| color: var(--nuxeo-icon-color, transparent); | ||
| padding: 0; | ||
| margin: 0; | ||
| opacity: 0.7; |
There was a problem hiding this comment.
Looks too dark in the UI, 3:1 ratio would be enough as mentioned in https://jira.nuxeo.com/browse/ELEMENTS-1554
There was a problem hiding this comment.
opacity less than 7 doesn't work here.
GuruprasadAnk1996
approved these changes
Dec 19, 2022
rakeshkumar1019
approved these changes
Dec 19, 2022
rajatgoel-gl
approved these changes
Dec 20, 2022
poonamyadav252
deleted the
imp-ELEMENTS-1554-improve-contrast-for-select-all-action
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.