Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ELEMENTS-1554: improve contrast for select all action #631

Merged
merged 1 commit into from Dec 20, 2022
Merged

ELEMENTS-1554: improve contrast for select all action #631

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions ui/widgets/nuxeo-checkmark.js
View file
Open in desktop
Expand Up @@ -54,11 +54,12 @@ import '../nuxeo-icons.js';
height: var(--nuxeo-checkmark-height, 18px);
cursor: pointer;
border-radius: 50%;
border: 2px solid var(--nuxeo-checkmark-border-color, var(--nuxeo-border, gray));
border: 2px solid var(--nuxeo-checkmark-border-color, var(--nuxeo-text-default, gray));
background-color: var(--nuxeo-checkmark-background-color, transparent);
color: var(--nuxeo-icon-color, transparent);
padding: 0;
margin: 0;
opacity: 0.7;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks too dark in the UI, 3:1 ratio would be enough as mentioned in https://jira.nuxeo.com/browse/ELEMENTS-1554

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opacity less than 7 doesn't work here.
image

}

:host([hidden]) {
Expand All @@ -70,7 +71,7 @@ import '../nuxeo-icons.js';
}

:host(:hover) {
border: 2px solid var(--nuxeo-checkmark-border-color, var(--nuxeo-border, gray));
border: 2px solid var(--nuxeo-checkmark-border-color, var(--nuxeo-text-default, gray));
background-color: var(--nuxeo-checkmark-background-color-hover, transparent);
color: var(--nuxeo-icon-color-hover, black);
}
Expand Down