Skip to content

Commit

Permalink
NXJS-129: fix const in for iteration failing in Firefox 50
Browse files Browse the repository at this point in the history
  • Loading branch information
gustavofp authored and troger committed Jan 16, 2018
1 parent 2ef0540 commit 04b00aa
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 5 deletions.
12 changes: 8 additions & 4 deletions lib/base.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ class Base {
*/
enrichers(enrichers, override = true) {
this._baseOptions.enrichers = override ? {} : this._baseOptions.enrichers;
for (const key of Object.keys(enrichers)) {
// eslint-disable-next-line prefer-const
for (let key of Object.keys(enrichers)) {
if (override) {
this._baseOptions.enrichers[key] = [...enrichers[key]];
} else {
Expand Down Expand Up @@ -105,7 +106,8 @@ class Base {
*/
fetchProperties(fetchProperties, override = true) {
this._baseOptions.fetchProperties = override ? {} : this._baseOptions.fetchProperties;
for (const key of Object.keys(fetchProperties)) {
// eslint-disable-next-line prefer-const
for (let key of Object.keys(fetchProperties)) {
if (override) {
this._baseOptions.fetchProperties[key] = [...fetchProperties[key]];
} else {
Expand Down Expand Up @@ -143,7 +145,8 @@ class Base {
*/
translateProperties(translateProperties, override = true) {
this._baseOptions.translateProperties = override ? {} : this._baseOptions.translateProperties;
for (const key of Object.keys(translateProperties)) {
// eslint-disable-next-line prefer-const
for (let key of Object.keys(translateProperties)) {
if (override) {
this._baseOptions.translateProperties[key] = [...translateProperties[key]];
} else {
Expand Down Expand Up @@ -184,7 +187,8 @@ class Base {
*/
headers(headers) {
this._baseOptions.headers = {};
for (const key of Object.keys(headers)) {
// eslint-disable-next-line prefer-const
for (let key of Object.keys(headers)) {
this._baseOptions.headers[key] = headers[key];
}
return this;
Expand Down
3 changes: 2 additions & 1 deletion lib/operation.js
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,8 @@ class Operation extends Base {
form.append('params', JSON.stringify(automationParams));

let inputIndex = 0;
for (const blob of input) {
// eslint-disable-next-line prefer-const
for (let blob of input) {
form.append(`input#${inputIndex}`, blob.content, blob.name);
inputIndex += 1;
}
Expand Down

0 comments on commit 04b00aa

Please sign in to comment.