Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WEBUI-232: set parent to root when none is provided #1155

Merged
merged 1 commit into from Feb 12, 2021
Merged

WEBUI-232: set parent to root when none is provided #1155

merged 1 commit into from Feb 12, 2021

Conversation

richardsd
Copy link
Contributor

No description provided.

@richardsd richardsd requested a review from a team as a code owner February 10, 2021 16:24
@nuxeojenkins
Copy link
Contributor

View issue in JIRA: WEBUI-232: Fix the creation of a subtopic under a new topic in a hierarchical vocabulary

@richardsd
Copy link
Contributor Author

richardsd commented Feb 10, 2021 •
edited

Pipeline https://qa.nuxeo.org/jenkins/job/web-ui-pipeline-rdias/56/ 🔵

@richardsd
Copy link
Contributor Author

vocabulary_management_no_parent

@nuxeo-web-ui-jx-bot
Copy link
Contributor

⭐ PR built and available in a preview environment nuxeo-nuxeo-web-ui-pr-1155 here

andreacornaglia
andreacornaglia reviewed Feb 10, 2021
View reviewed changes
Copy link
Contributor

@andreacornaglia andreacornaglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused by the commit message since it says to set parent to '' but in the code we set it to the this._root.properties.id

@richardsd
Copy link
Contributor Author

richardsd commented Feb 10, 2021 •
edited

I am confused by the commit message since it says to set parent to '' but in the code we set it to the this._root.properties.id

You're right. It is a poor commit message. I used an empty string in the first place, but then realized we should be using the root (which in fact is an empty string, but that is just a detail). I'll reword the commit message.

@richardsd richardsd changed the title WEBUI-232: set parent to '' when none is provided WEBUI-232: set parent to root when none is provided Feb 11, 2021
@richardsd richardsd force-pushed the fix-WEBUI-232-subtopic-creation-hierarchical-vocab branch from c5c355e to ac28dac Compare February 11, 2021 12:50
@richardsd richardsd requested review from Gabez0r, mnixo, semisse and a team February 11, 2021 12:51
@richardsd richardsd force-pushed the fix-WEBUI-232-subtopic-creation-hierarchical-vocab branch from ac28dac to d525321 Compare February 11, 2021 15:26
This was referenced Feb 11, 2021
Merged
Merged
@nuxeo-web-ui-jx-bot
Copy link
Contributor

⭐ PR built and available in a preview environment nuxeo-nuxeo-web-ui-pr-1155 here

Gabez0r
Gabez0r previously approved these changes Feb 11, 2021
View reviewed changes
@richardsd richardsd dismissed stale reviews from mnixo and Gabez0r via 5ed4a9f February 12, 2021 10:08
@richardsd richardsd force-pushed the fix-WEBUI-232-subtopic-creation-hierarchical-vocab branch from d525321 to 5ed4a9f Compare February 12, 2021 10:08
@nuxeo-web-ui-jx-bot
Copy link
Contributor

⭐ PR built and available in a preview environment nuxeo-nuxeo-web-ui-pr-1155 here

@richardsd richardsd merged commit b9e1294 into master Feb 12, 2021
@richardsd richardsd deleted the fix-WEBUI-232-subtopic-creation-hierarchical-vocab branch February 12, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnixo mnixo mnixo approved these changes

@Gabez0r Gabez0r Gabez0r approved these changes

@nelsonsilva nelsonsilva Awaiting requested review from nelsonsilva

@semisse semisse Awaiting requested review from semisse

@andreacornaglia andreacornaglia Awaiting requested review from andreacornaglia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
6 participants
@richardsd @nuxeojenkins @nuxeo-web-ui-jx-bot @mnixo @andreacornaglia @Gabez0r