Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEBUI-321: fix aria-label on nuxeo-document-create-button (backport 3.0.x) #1226

Conversation

semisse
Copy link
Collaborator

@semisse semisse commented May 7, 2021

No description provided.

@semisse semisse requested a review from a team as a code owner May 7, 2021 18:03
@nuxeojenkins
Copy link
Contributor

View issue in JIRA: WEBUI-321: make nuxeo-document-create-button accessible

@semisse semisse changed the title WEBUI-321: fix aria-label on nuxeo-document-create-button WEBUI-321: fix aria-label on nuxeo-document-create-button (backport 3.0.x) May 7, 2021
@nuxeo-web-ui-jx-bot
Copy link
Contributor

⭐ PR built and available in a preview environment nuxeo-nuxeo-web-ui-pr-1226 here

@semisse
Copy link
Collaborator Author

semisse commented May 26, 2021

Looks like AxeDevTools is picking this as a false positive because it can't access the nuxeo-tooltip even though it is present. However, voice-over on mac can pick it up and read the proper aria-label as you can check in the video:
https://user-images.githubusercontent.com/1880896/119638484-9dba8b80-be0e-11eb-8a64-e4de086ea8ee.mov

AxeDevTools report:

Fix at least one (1) of these issues:
Element does not have text that is visible to screen readers

aria-label attribute does not exist or is empty

aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty

Element has no title attribute

I will close this PR since the problem is already fixed.

@semisse semisse closed this May 26, 2021
@semisse semisse deleted the fix-WEBUI-321-nuxeoDocumentCreateButtonA11y-3.0.x branch May 27, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants