WEBUI-1507-group test case #2235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alokhyland
force-pushed
the
fix-WEBUI-1507-update-group-test-case
branch
2 times, most recently
from
0b09b1e
to
bde34b7
Compare
alokhyland
requested review from
rahuljain-dev
and removed request for
MohinishSah
madhurkulshrestha-hyland
requested changes
May 7, 2024
| return currentText === searchTerm; | ||
| }; | ||
| await driver.waitUntil(async () => { | ||
| const getElements = await this.el.elements('nuxeo-card[name="groups"] .table [name="id"]'); |
There was a problem hiding this comment.
This is repetitive line which can be taken out of the loop
alokhyland
force-pushed
the
fix-WEBUI-1507-update-group-test-case
branch
from
bde34b7
to
84afae3
Compare
rakeshkumar1019
approved these changes
May 8, 2024
madhurkulshrestha-hyland
approved these changes
May 8, 2024
rahuljain-dev
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.